Add missing error check on PEM_write_bio_CMS()

nielsdos · nielsdos · commit 51ea4a680db4 · 2023-03-05T22:06:23.000+01:00
On failure, this function returns 0. 2 other callers of this function
already check the return value, but this one was missed.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -5991,7 +5991,11 @@ PHP_FUNCTION(openssl_cms_verify)
 			}
 
 			if (p7bout) {
-				PEM_write_bio_CMS(p7bout, cms);
+				if (PEM_write_bio_CMS(p7bout, cms) == 0) {
+					php_error_docref(NULL, E_WARNING, "Failed to write CMS to file");
+					php_openssl_store_errors();
+					RETVAL_FALSE;
+				}
 			}
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -5991,7 +5991,11 @@ PHP_FUNCTION(openssl_cms_verify)`
`5991`	`5991`	`}`
`5992`	`5992`
`5993`	`5993`	`if (p7bout) {`
`5994`		`- PEM_write_bio_CMS(p7bout, cms);`
	`5994`	`+ if (PEM_write_bio_CMS(p7bout, cms) == 0) {`
	`5995`	`+ php_error_docref(NULL, E_WARNING, "Failed to write CMS to file");`
	`5996`	`+ php_openssl_store_errors();`
	`5997`	`+ RETVAL_FALSE;`
	`5998`	`+ }`
`5995`	`5999`	`}`
`5996`	`6000`	`}`
`5997`	`6001`	`} else {`