Skip to content

Commit 5005445

Browse files
committed
Mark curl tests using http2.golang.org as XFAIL
http2.golang.org/serverpush has been retired[1], so we need to come up with an alternative. Until then, we mark the relevant tests as XFAIL (although bug77535.phpt passes, what might be an indication that the test needs further revision). To avoid waiting for the timeout, we also unconditionally skip these tests for now. [1] <golang/go#49301> Closes GH-7829.
1 parent e76ddbd commit 5005445

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

ext/curl/tests/bug76675.phpt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
Bug #76675 (Segfault with H2 server push write/writeheader handlers)
3+
--XFAIL--
4+
http2.golang.org/serverpush is gone
35
--SKIPIF--
46
<?php
57
include 'skipif.inc';
@@ -10,6 +12,7 @@ $curl_version = curl_version();
1012
if ($curl_version['version_number'] < 0x073d00) {
1113
exit("skip: test may crash with curl < 7.61.0");
1214
}
15+
die("skip test is slow due to timeout, and XFAILs anyway");
1316
?>
1417
--FILE--
1518
<?php

ext/curl/tests/bug77535.phpt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
Bug #77535 (Invalid callback, h2 server push)
3+
--XFAIL--
4+
http2.golang.org/serverpush is gone
35
--SKIPIF--
46
<?php
57
include 'skipif.inc';
@@ -10,6 +12,7 @@ $curl_version = curl_version();
1012
if ($curl_version['version_number'] < 0x073d00) {
1113
exit("skip: test may crash with curl < 7.61.0");
1214
}
15+
die("skip test is slow due to timeout, and XFAILs anyway");
1316
?>
1417
--FILE--
1518
<?php

0 commit comments

Comments
 (0)