Skip to content

Commit 4f63c10

Browse files
committed
Rename variables
1 parent 92e83c8 commit 4f63c10

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

Zend/zend_inheritance.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1632,7 +1632,7 @@ ZEND_API void zend_do_inheritance_ex(zend_class_entry *ce, zend_class_entry *par
16321632

16331633
static zend_always_inline bool check_trait_property_or_constant_value_compatibility(zend_class_entry *ce, zval *op1, zval *op2) /* {{{ */
16341634
{
1635-
bool compatible;
1635+
bool is_compatible;
16361636
zval op1_tmp, op2_tmp;
16371637

16381638
/* if any of the values is a constant, we try to resolve it */
@@ -1647,7 +1647,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
16471647
op2 = &op2_tmp;
16481648
}
16491649

1650-
compatible = !fast_is_not_identical_function(op1, op2);
1650+
is_compatible = !fast_is_not_identical_function(op1, op2);
16511651

16521652
if (op1 == &op1_tmp) {
16531653
zval_ptr_dtor_nogc(&op1_tmp);
@@ -1656,7 +1656,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
16561656
zval_ptr_dtor_nogc(&op2_tmp);
16571657
}
16581658

1659-
return compatible;
1659+
return is_compatible;
16601660
}
16611661
/* }}} */
16621662

@@ -2243,7 +2243,7 @@ static zend_class_entry* find_first_constant_definition(zend_class_entry *ce, ze
22432243
static bool do_trait_constant_check(
22442244
zend_class_entry *ce, zend_class_constant *trait_constant, zend_string *name, zend_class_entry **traits, size_t current_trait
22452245
) {
2246-
bool compatible = false;
2246+
bool is_compatible = false;
22472247
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_FINAL;
22482248

22492249
zval *zv = zend_hash_find_known_hash(&ce->constants_table, name);
@@ -2257,17 +2257,17 @@ static bool do_trait_constant_check(
22572257
return true;
22582258
}
22592259
if ((ZEND_CLASS_CONST_FLAGS(trait_constant) & flags_mask) == (ZEND_CLASS_CONST_FLAGS(old_constant) & flags_mask)) {
2260-
compatible = check_trait_property_or_constant_value_compatibility(ce, &trait_constant->value, &old_constant->value);
2260+
is_compatible = check_trait_property_or_constant_value_compatibility(ce, &trait_constant->value, &old_constant->value);
22612261
}
2262-
if (!compatible) {
2262+
if (!is_compatible) {
22632263
zend_error_noreturn(E_COMPILE_ERROR,
22642264
"%s and %s define the same constant (%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed",
22652265
ZSTR_VAL(find_first_constant_definition(ce, traits, current_trait, name, old_constant->ce)->name),
22662266
ZSTR_VAL(trait_constant->ce->name),
22672267
ZSTR_VAL(name),
22682268
ZSTR_VAL(ce->name));
22692269
}
2270-
return compatible;
2270+
return is_compatible;
22712271
}
22722272
/* }}} */
22732273

@@ -2336,13 +2336,13 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
23362336
zend_hash_del(&ce->properties_info, prop_name);
23372337
flags |= ZEND_ACC_CHANGED;
23382338
} else {
2339-
bool compatible = false;
2339+
bool is_compatible = false;
23402340
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_STATIC | ZEND_ACC_READONLY;
23412341

23422342
if ((colliding_prop->flags & flags_mask) == (flags & flags_mask) &&
23432343
property_types_compatible(property_info, colliding_prop) == INHERITANCE_SUCCESS
23442344
) {
2345-
/* the flags are identical, thus, the properties may be compatible */
2345+
/* the flags are identical, thus, the properties may be is_compatible */
23462346
zval *op1, *op2;
23472347

23482348
if (flags & ZEND_ACC_STATIC) {
@@ -2354,10 +2354,10 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
23542354
op1 = &ce->default_properties_table[OBJ_PROP_TO_NUM(colliding_prop->offset)];
23552355
op2 = &traits[i]->default_properties_table[OBJ_PROP_TO_NUM(property_info->offset)];
23562356
}
2357-
compatible = check_trait_property_or_constant_value_compatibility(ce, op1, op2);
2357+
is_compatible = check_trait_property_or_constant_value_compatibility(ce, op1, op2);
23582358
}
23592359

2360-
if (!compatible) {
2360+
if (!is_compatible) {
23612361
zend_error_noreturn(E_COMPILE_ERROR,
23622362
"%s and %s define the same property ($%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed",
23632363
ZSTR_VAL(find_first_property_definition(ce, traits, i, prop_name, colliding_prop->ce)->name),

0 commit comments

Comments
 (0)