@@ -1632,7 +1632,7 @@ ZEND_API void zend_do_inheritance_ex(zend_class_entry *ce, zend_class_entry *par
1632
1632
1633
1633
static zend_always_inline bool check_trait_property_or_constant_value_compatibility (zend_class_entry * ce , zval * op1 , zval * op2 ) /* {{{ */
1634
1634
{
1635
- bool compatible ;
1635
+ bool is_compatible ;
1636
1636
zval op1_tmp , op2_tmp ;
1637
1637
1638
1638
/* if any of the values is a constant, we try to resolve it */
@@ -1647,7 +1647,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
1647
1647
op2 = & op2_tmp ;
1648
1648
}
1649
1649
1650
- compatible = !fast_is_not_identical_function (op1 , op2 );
1650
+ is_compatible = !fast_is_not_identical_function (op1 , op2 );
1651
1651
1652
1652
if (op1 == & op1_tmp ) {
1653
1653
zval_ptr_dtor_nogc (& op1_tmp );
@@ -1656,7 +1656,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
1656
1656
zval_ptr_dtor_nogc (& op2_tmp );
1657
1657
}
1658
1658
1659
- return compatible ;
1659
+ return is_compatible ;
1660
1660
}
1661
1661
/* }}} */
1662
1662
@@ -2243,7 +2243,7 @@ static zend_class_entry* find_first_constant_definition(zend_class_entry *ce, ze
2243
2243
static bool do_trait_constant_check (
2244
2244
zend_class_entry * ce , zend_class_constant * trait_constant , zend_string * name , zend_class_entry * * traits , size_t current_trait
2245
2245
) {
2246
- bool compatible = false;
2246
+ bool is_compatible = false;
2247
2247
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_FINAL ;
2248
2248
2249
2249
zval * zv = zend_hash_find_known_hash (& ce -> constants_table , name );
@@ -2257,17 +2257,17 @@ static bool do_trait_constant_check(
2257
2257
return true;
2258
2258
}
2259
2259
if ((ZEND_CLASS_CONST_FLAGS (trait_constant ) & flags_mask ) == (ZEND_CLASS_CONST_FLAGS (old_constant ) & flags_mask )) {
2260
- compatible = check_trait_property_or_constant_value_compatibility (ce , & trait_constant -> value , & old_constant -> value );
2260
+ is_compatible = check_trait_property_or_constant_value_compatibility (ce , & trait_constant -> value , & old_constant -> value );
2261
2261
}
2262
- if (!compatible ) {
2262
+ if (!is_compatible ) {
2263
2263
zend_error_noreturn (E_COMPILE_ERROR ,
2264
2264
"%s and %s define the same constant (%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed" ,
2265
2265
ZSTR_VAL (find_first_constant_definition (ce , traits , current_trait , name , old_constant -> ce )-> name ),
2266
2266
ZSTR_VAL (trait_constant -> ce -> name ),
2267
2267
ZSTR_VAL (name ),
2268
2268
ZSTR_VAL (ce -> name ));
2269
2269
}
2270
- return compatible ;
2270
+ return is_compatible ;
2271
2271
}
2272
2272
/* }}} */
2273
2273
@@ -2336,13 +2336,13 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
2336
2336
zend_hash_del (& ce -> properties_info , prop_name );
2337
2337
flags |= ZEND_ACC_CHANGED ;
2338
2338
} else {
2339
- bool compatible = false;
2339
+ bool is_compatible = false;
2340
2340
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_STATIC | ZEND_ACC_READONLY ;
2341
2341
2342
2342
if ((colliding_prop -> flags & flags_mask ) == (flags & flags_mask ) &&
2343
2343
property_types_compatible (property_info , colliding_prop ) == INHERITANCE_SUCCESS
2344
2344
) {
2345
- /* the flags are identical, thus, the properties may be compatible */
2345
+ /* the flags are identical, thus, the properties may be is_compatible */
2346
2346
zval * op1 , * op2 ;
2347
2347
2348
2348
if (flags & ZEND_ACC_STATIC ) {
@@ -2354,10 +2354,10 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
2354
2354
op1 = & ce -> default_properties_table [OBJ_PROP_TO_NUM (colliding_prop -> offset )];
2355
2355
op2 = & traits [i ]-> default_properties_table [OBJ_PROP_TO_NUM (property_info -> offset )];
2356
2356
}
2357
- compatible = check_trait_property_or_constant_value_compatibility (ce , op1 , op2 );
2357
+ is_compatible = check_trait_property_or_constant_value_compatibility (ce , op1 , op2 );
2358
2358
}
2359
2359
2360
- if (!compatible ) {
2360
+ if (!is_compatible ) {
2361
2361
zend_error_noreturn (E_COMPILE_ERROR ,
2362
2362
"%s and %s define the same property ($%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed" ,
2363
2363
ZSTR_VAL (find_first_property_definition (ce , traits , i , prop_name , colliding_prop -> ce )-> name ),
0 commit comments