Fix logic error in PDO

Girgias · Girgias · commit 4dfbf07644ba · 2020-09-25T16:28:48.000+01:00
diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
@@ -1873,7 +1873,8 @@ int pdo_stmt_setup_fetch_mode(INTERNAL_FUNCTION_PARAMETERS, pdo_stmt_t *stmt, in
 			mode = Z_LVAL(args[skip]);
 			flags = mode & PDO_FETCH_FLAGS;
 
-			retval = pdo_stmt_verify_mode(stmt, mode, 0);
+			/* pdo_stmt_verify_mode() returns a boolean value */
+			retval = pdo_stmt_verify_mode(stmt, mode, 0) ? SUCCESS : FAILURE;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1873,7 +1873,8 @@ int pdo_stmt_setup_fetch_mode(INTERNAL_FUNCTION_PARAMETERS, pdo_stmt_t *stmt, in`
`1873`	`1873`	`mode = Z_LVAL(args[skip]);`
`1874`	`1874`	`flags = mode & PDO_FETCH_FLAGS;`
`1875`	`1875`
`1876`		`- retval = pdo_stmt_verify_mode(stmt, mode, 0);`
	`1876`	`+ /* pdo_stmt_verify_mode() returns a boolean value */`
	`1877`	`+ retval = pdo_stmt_verify_mode(stmt, mode, 0) ? SUCCESS : FAILURE;`
`1877`	`1878`	`}`
`1878`	`1879`	`}`
`1879`	`1880`