Fix gidlist allocation leak on error

nikic · nikic · commit 454d2975641c · 2021-04-11T10:37:40.000+02:00
diff --git a/ext/posix/posix.c b/ext/posix/posix.c
@@ -579,6 +579,7 @@ PHP_FUNCTION(posix_getgroups)
 	gidlist = emalloc(sizeof(gid_t) * result);
 	if ((result = getgroups(result, gidlist)) < 0) {
 		POSIX_G(last_error) = errno;
+		efree(gidlist);
 		RETURN_FALSE;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -579,6 +579,7 @@ PHP_FUNCTION(posix_getgroups)`
`579`	`579`	`gidlist = emalloc(sizeof(gid_t) * result);`
`580`	`580`	`if ((result = getgroups(result, gidlist)) < 0) {`
`581`	`581`	`POSIX_G(last_error) = errno;`
	`582`	`+ efree(gidlist);`
`582`	`583`	`RETURN_FALSE;`
`583`	`584`	`}`
`584`	`585`