Skip to content

Commit 4542cc6

Browse files
committed
Merge branch 'PHP-8.3'
* PHP-8.3: Fix windows rename test directories clashing
2 parents 86ebc18 + 22ac07a commit 4542cc6

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

ext/standard/tests/file/rename_variation-win32.phpt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,27 @@ require __DIR__.'/file.inc';
1212

1313
/* create directory */
1414
$file_path = __DIR__;
15-
mkdir("$file_path/rename_variation");
15+
mkdir("$file_path/rename_variation-win32");
1616

1717
/* rename files across directories */
1818
echo "*** Testing rename() : rename files across directories ***\n";
1919
$src_filenames = array(
20-
"$file_path/rename_variation/rename_variation.tmp",
20+
"$file_path/rename_variation-win32/rename_variation.tmp",
2121

2222
/* Testing a file trailing slash */
23-
"$file_path/rename_variation/rename_variation.tmp/",
23+
"$file_path/rename_variation-win32/rename_variation.tmp/",
2424

2525
/* Testing file with double slashes */
26-
"$file_path/rename_variation//rename_variation.tmp",
27-
"$file_path//rename_variation//rename_variation.tmp",
26+
"$file_path/rename_variation-win32//rename_variation.tmp",
27+
"$file_path//rename_variation-win32//rename_variation.tmp",
2828
);
2929

3030
$counter = 1;
3131

3232
/* loop through each $file and rename it to rename_variation2.tmp */
3333
foreach($src_filenames as $src_filename) {
3434
echo "-- Iteration $counter --\n";
35-
$fp = fopen("$file_path/rename_variation/rename_variation.tmp", "w");
35+
$fp = fopen("$file_path/rename_variation-win32/rename_variation.tmp", "w");
3636
fclose($fp);
3737
$dest_filename = "$file_path/rename_variation2.tmp";
3838
var_dump( rename($src_filename, $dest_filename) );
@@ -51,7 +51,7 @@ echo "Done\n";
5151
--CLEAN--
5252
<?php
5353
$file_path = __DIR__;
54-
rmdir($file_path."/rename_variation");
54+
rmdir($file_path."/rename_variation-win32");
5555
?>
5656
--EXPECTF--
5757
*** Testing rename() : rename files across directories ***
@@ -61,7 +61,7 @@ bool(false)
6161
bool(true)
6262
-- Iteration 2 --
6363

64-
Warning: rename(%s/rename_variation/rename_variation.tmp/,%s/rename_variation2.tmp): The filename, directory name, or volume label syntax is incorrect (code: 123) in %s on line %d
64+
Warning: rename(%s/rename_variation-win32/rename_variation.tmp/,%s/rename_variation2.tmp): The filename, directory name, or volume label syntax is incorrect (code: 123) in %s on line %d
6565
bool(false)
6666
bool(false)
6767
bool(false)

ext/standard/tests/file/rename_variation1-win32.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@ $file_path = __DIR__;
1717
echo "\n*** Testing rename() : renaming directory across directories ***\n";
1818
$src_dirs = array (
1919
/* Testing simple directory tree */
20-
"$file_path/rename_variation/",
20+
"$file_path/rename_variation1-win32/",
2121

2222
/* Testing a dir with trailing slash */
23-
"$file_path/rename_variation/",
23+
"$file_path/rename_variation1-win32/",
2424

2525
/* Testing dir with double trailing slashes */
26-
"$file_path//rename_variation//",
26+
"$file_path//rename_variation1-win32//",
2727
);
2828

29-
$dest_dir = "$file_path/rename_variation_dir";
29+
$dest_dir = "$file_path/rename_variation1-win32_dir";
3030

3131
// create the $dest_dir
3232
mkdir($dest_dir);
@@ -38,7 +38,7 @@ foreach($src_dirs as $src_dir) {
3838
echo "-- Iteration $counter --\n";
3939

4040
// create the src dir
41-
mkdir("$file_path/rename_variation/");
41+
mkdir("$file_path/rename_variation1-win32/");
4242
// rename the src dir to a new dir in dest dir
4343
var_dump( rename($src_dir, $dest_dir."/new_dir") );
4444
// ensure that dir was renamed
@@ -55,7 +55,7 @@ echo "Done\n";
5555
--CLEAN--
5656
<?php
5757
$file_path = __DIR__;
58-
rmdir($file_path."/rename_variation_dir");
58+
rmdir($file_path."/rename_variation1-win32_dir");
5959
?>
6060
--EXPECT--
6161
*** Testing rename() : renaming directory across directories ***

0 commit comments

Comments
 (0)