Fixed bug GH-13193 again

nielsdos · nielsdos · commit 447d143b9d52 · 2025-03-21T11:47:52.000+01:00
Closes GH-13193.
diff --git a/NEWS b/NEWS
@@ -7,6 +7,8 @@ PHP                                                                        NEWS
     (Arnaud)
   . Fixed bug GH-15367 (dl() of module with aliased class crashes in shutdown).
     (Arnaud)
+  . Fixed bug GH-13193 again (Significant performance degradation in 'foreach').
+    (nielsdos)
 
 - DOM:
   . Fix weird unpack behaviour in DOM. (nielsdos)
diff --git a/Zend/zend_gc.c b/Zend/zend_gc.c
@@ -1783,7 +1783,7 @@ ZEND_API int zend_gc_collect_cycles(void)
 	bool did_rerun_gc = 0;
 
 	zend_hrtime_t start_time = zend_hrtime();
-	if (GC_G(num_roots) && GC_G(gc_active)) {
+	if (GC_G(num_roots) && !GC_G(gc_active)) {
 		zend_gc_remove_root_tmpvars();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1783,7 +1783,7 @@ ZEND_API int zend_gc_collect_cycles(void)`
`1783`	`1783`	`bool did_rerun_gc = 0;`
`1784`	`1784`
`1785`	`1785`	`zend_hrtime_t start_time = zend_hrtime();`
`1786`		`- if (GC_G(num_roots) && GC_G(gc_active)) {`
	`1786`	`+ if (GC_G(num_roots) && !GC_G(gc_active)) {`
`1787`	`1787`	`zend_gc_remove_root_tmpvars();`
`1788`	`1788`	`}`
`1789`	`1789`