Skip to content

Commit 437010d

Browse files
committed
Feedback changes
1 parent c2b33d8 commit 437010d

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Zend/zend_fibers.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ ZEND_METHOD(Fiber, start)
450450
fiber->fci.named_params = named_params;
451451

452452
if (!zend_fiber_init_context(&fiber->context, zend_fiber_execute, EG(fiber_stack_size))) {
453-
zend_throw_error(NULL, "Could not create fiber context");
453+
zend_throw_exception(NULL, "Could not create fiber context", 0);
454454
RETURN_THROWS();
455455
}
456456

@@ -486,6 +486,8 @@ ZEND_METHOD(Fiber, suspend)
486486
RETURN_THROWS();
487487
}
488488

489+
ZEND_ASSERT(fiber->status == ZEND_FIBER_STATUS_RUNNING);
490+
489491
if (value) {
490492
ZVAL_COPY(&fiber->value, value);
491493
} else {

Zend/zend_fibers.stub.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?php
22

3-
/**
4-
* @generate-class-entries
5-
* @strict-properties
6-
*/
3+
/** @generate-class-entries */
74

5+
/** @strict-properties */
86
final class Fiber
97
{
108
public function __construct(callable $callback) {}

Zend/zend_fibers_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 6d3eff364c5fc57d03b82e244b780d0b783d6eaf */
2+
* Stub hash: 5f63019ce24efa7b5426f172d68a0f9f705a3bd5 */
33

44
ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Fiber___construct, 0, 0, 1)
55
ZEND_ARG_TYPE_INFO(0, callback, IS_CALLABLE, 0)

0 commit comments

Comments
 (0)