Skip to content

Commit 4199b72

Browse files
committed
Fix GH-10315: FPM unknown child alert not valid
This changes the log level for an unknown child during wait as this is not unuasual if FPM master has pid 1 and also possible in some cases for higher pid processes. Based on that and the fact that this is not really a problem, there is just a debug level message emitted for pid 1 and for higher pid a warning is emitted. Closes GH-10319
1 parent fe2dc2b commit 4199b72

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ PHP NEWS
1717
- FFI:
1818
. Fixed incorrect bitshifting and masking in ffi bitfield. (nielsdos)
1919

20+
- FPM:
21+
. Fixed bug GH-10315 (FPM unknown child alert not valid). (Jakub Zelenka)
22+
2023
- Opcache:
2124
. Fix incorrect page_size check. (nielsdos)
2225

sapi/fpm/fpm/fpm_children.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,10 @@ void fpm_children_bury(void)
297297
break;
298298
}
299299
}
300+
} else if (fpm_globals.parent_pid == 1) {
301+
zlog(ZLOG_DEBUG, "unknown child (%d) exited %s - most likely an orphan process (master process is the init process)", pid, buf);
300302
} else {
301-
zlog(ZLOG_ALERT, "oops, unknown child (%d) exited %s. Please open a bug report (https://github.com/php/php-src/issues).", pid, buf);
303+
zlog(ZLOG_WARNING, "unknown child (%d) exited %s - potentially a bug or pre exec child (e.g. s6-notifyoncheck)", pid, buf);
302304
}
303305
}
304306
}

0 commit comments

Comments
 (0)