Skip to content

Commit 40908f3

Browse files
authored
Test JIT on clang/asan build (#13006)
Clang enables the pointer-overflow check which is incompatble with the tracing JIT. We can still test the JIT by disabling this check.
1 parent 7009149 commit 40908f3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/push.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ jobs:
123123
configurationParameters: >-
124124
--${{ matrix.debug && 'enable' || 'disable' }}-debug
125125
--${{ matrix.zts && 'enable' || 'disable' }}-zts
126-
${{ matrix.asan && 'CFLAGS="-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC" LDFLAGS="-fsanitize=undefined,address" CC=clang-16 CXX=clang++-16 --disable-opcache-jit' || '' }}
126+
${{ matrix.asan && 'CFLAGS="-fsanitize=undefined,address -fno-sanitize=pointer-overflow -DZEND_TRACK_ARENA_ALLOC" LDFLAGS="-fsanitize=undefined,address -fno-sanitize=pointer-overflow" CC=clang-16 CXX=clang++-16' || '' }}
127127
skipSlow: ${{ matrix.asan }}
128128
- name: make
129129
run: make -j$(/usr/bin/nproc) >/dev/null
@@ -137,11 +137,11 @@ jobs:
137137
uses: ./.github/actions/test-linux
138138
with:
139139
testArtifacts: ${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}
140-
- name: Test ${{ matrix.asan && 'OpCache' || 'Tracing JIT' }}
140+
- name: Test Tracing JIT
141141
uses: ./.github/actions/test-linux
142142
with:
143-
testArtifacts: ${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || '' }}_${{ matrix.asan && 'OpCache' || 'Tracing JIT' }}
144-
jitType: ${{ matrix.asan && 'disable' || 'tracing' }}
143+
testArtifacts: ${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || '' }}_Tracing JIT
144+
jitType: tracing
145145
runTestsParameters: >-
146146
-d zend_extension=opcache.so
147147
-d opcache.enable_cli=1

0 commit comments

Comments
 (0)