Skip to content

Commit 3e9dac2

Browse files
committed
Don't rand() in test
Instead use port 0 to get a free port from the OS.
1 parent 5c40491 commit 3e9dac2

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

ext/sockets/tests/socket_connect_params.phpt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,17 @@ fa@php.net
1111
?>
1212
--FILE--
1313
<?php
14-
$rand = rand(1,999);
15-
$s_c = socket_create_listen(31330+$rand);
16-
// wrong parameter count
17-
$s_w = socket_connect();
18-
$s_w = socket_connect($s_c);
19-
$s_w = socket_connect($s_c, '0.0.0.0');
20-
$s_w = socket_connect($s_c, '0.0.0.0', 31330+$rand);
2114

22-
socket_close($s_c);
15+
$s_c = socket_create_listen(0);
16+
socket_getsockname($s_c, $addr, $port);
17+
18+
// wrong parameter count
19+
$s_w = socket_connect();
20+
$s_w = socket_connect($s_c);
21+
$s_w = socket_connect($s_c, '0.0.0.0');
22+
$s_w = socket_connect($s_c, '0.0.0.0', $port);
23+
24+
socket_close($s_c);
2325

2426
?>
2527
--EXPECTF--

0 commit comments

Comments
 (0)