Promote warning to exception in ZipArchive::extractTo()

kocsismate · kocsismate · commit 3dec2a24f943 · 2020-05-06T09:34:21.000+02:00
diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c
@@ -2809,10 +2809,9 @@ static ZIPARCHIVE_METHOD(extractTo)
 					}
 				}
 				break;
-			case IS_LONG:
 			default:
-				php_error_docref(NULL, E_WARNING, "Invalid argument, expect string or array of strings");
-				break;
+				zend_argument_type_error(2, "must be of type array|string, %s given", zend_zval_type_name(zval_files));
+				RETURN_THROWS();
 		}
 	} else {
 		/* Extract all files */

Original file line number	Diff line number	Diff line change
`@@ -2809,10 +2809,9 @@ static ZIPARCHIVE_METHOD(extractTo)`
`2809`	`2809`	`}`
`2810`	`2810`	`}`
`2811`	`2811`	`break;`
`2812`		`- case IS_LONG:`
`2813`	`2812`	`default:`
`2814`		`- php_error_docref(NULL, E_WARNING, "Invalid argument, expect string or array of strings");`
`2815`		`- break;`
	`2813`	`+ zend_argument_type_error(2, "must be of type array\|string, %s given", zend_zval_type_name(zval_files));`
	`2814`	`+ RETURN_THROWS();`
`2816`	`2815`	`}`
`2817`	`2816`	`} else {`
`2818`	`2817`	`/* Extract all files */`