Show error in child process if exec fails (in proc_open)

alexdowad · alexdowad · commit 3dabfa985339 · 2020-05-01T21:26:13.000+02:00
diff --git a/ext/standard/proc_open.c b/ext/standard/proc_open.c
@@ -1096,7 +1096,9 @@ PHP_FUNCTION(proc_open)
 			}
 		}
 
-		/* Show errors from exec!! */
+		/* If execvp/execle/execl are successful, we will never reach here
+		 * Display error and exit with non-zero (error) status code */
+		php_error_docref(NULL, E_WARNING, "Exec failed - %s", strerror(errno));
 		_exit(127);
 	} else if (child < 0) {
 		/* failed to fork() */

Original file line number	Diff line number	Diff line change
`@@ -1096,7 +1096,9 @@ PHP_FUNCTION(proc_open)`
`1096`	`1096`	`}`
`1097`	`1097`	`}`
`1098`	`1098`
`1099`		`- /* Show errors from exec!! */`
	`1099`	`+ /* If execvp/execle/execl are successful, we will never reach here`
	`1100`	`+ * Display error and exit with non-zero (error) status code */`
	`1101`	`+ php_error_docref(NULL, E_WARNING, "Exec failed - %s", strerror(errno));`
`1100`	`1102`	`_exit(127);`
`1101`	`1103`	`} else if (child < 0) {`
`1102`	`1104`	`/* failed to fork() */`