Fix PdoRow leak

nikic · nikic · commit 3d7959c87b26 · 2015-04-16T21:08:29.000+02:00
PdoStatement should only hold a weakref to the PdoRow.
diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
@@ -262,7 +262,8 @@ static void get_lazy_object(pdo_stmt_t *stmt, zval *return_value) /* {{{ */
 		zend_object_std_init(&row->std, pdo_row_ce);
 		ZVAL_OBJ(&stmt->lazy_object_ref, &row->std);
 		row->std.handlers = &pdo_row_object_handlers;
-		stmt->std.gc.refcount++;
+		GC_REFCOUNT(&stmt->std)++;
+		GC_REFCOUNT(&row->std)--;
 	}
 	ZVAL_COPY(return_value, &stmt->lazy_object_ref);
 }

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,8 @@ static void get_lazy_object(pdo_stmt_t stmt, zval return_value) /* {{{ */`
`262`	`262`	`zend_object_std_init(&row->std, pdo_row_ce);`
`263`	`263`	`ZVAL_OBJ(&stmt->lazy_object_ref, &row->std);`
`264`	`264`	`row->std.handlers = &pdo_row_object_handlers;`
`265`		`- stmt->std.gc.refcount++;`
	`265`	`+ GC_REFCOUNT(&stmt->std)++;`
	`266`	`+ GC_REFCOUNT(&row->std)--;`
`266`	`267`	`}`
`267`	`268`	`ZVAL_COPY(return_value, &stmt->lazy_object_ref);`
`268`	`269`	`}`