Merge branch 'PHP-7.2' into PHP-7.3

nikic · nikic · commit 3c42471ef84d · 2019-10-02T12:07:19.000+02:00
diff --git a/Zend/tests/halt_compiler5.phpt b/Zend/tests/halt_compiler5.phpt
@@ -0,0 +1,8 @@
+--TEST--
+Using __COMPILER_HALF_OFFSET__ with trailing {} (OSS-Fuzz #17895)
+--FILE--
+<?php
+__COMPILER_HALT_OFFSET__;
+{}
+--EXPECTF--
+Warning: Use of undefined constant __COMPILER_HALT_OFFSET__ - assumed '__COMPILER_HALT_OFFSET__' (this will throw an Error in a future version of PHP) in %s on line %d
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -7764,6 +7764,9 @@ void zend_compile_const(znode *result, zend_ast *ast) /* {{{ */
 
 		while (last && last->kind == ZEND_AST_STMT_LIST) {
 			zend_ast_list *list = zend_ast_get_list(last);
+			if (list->children == 0) {
+				break;
+			}
 			last = list->child[list->children-1];
 		}
 		if (last && last->kind == ZEND_AST_HALT_COMPILER) {

Original file line number	Diff line number	Diff line change
`@@ -7764,6 +7764,9 @@ void zend_compile_const(znode result, zend_ast ast) /* {{{ */`
`7764`	`7764`
`7765`	`7765`	`while (last && last->kind == ZEND_AST_STMT_LIST) {`
`7766`	`7766`	`zend_ast_list *list = zend_ast_get_list(last);`
	`7767`	`+ if (list->children == 0) {`
	`7768`	`+ break;`
	`7769`	`+ }`
`7767`	`7770`	`last = list->child[list->children-1];`
`7768`	`7771`	`}`
`7769`	`7772`	`if (last && last->kind == ZEND_AST_HALT_COMPILER) {`