Implement GH-12908: Show attribute name/class in ReflectionAttribute dump

This is consistent with how many other Reflection classes have a name
field, and it makes debugging easier.

Closes GH-12908.
Closes GH-12917.

Author: nielsdos

NEWS

@@ -111,6 +111,10 @@ POSIX:
 PSpell:
   . Moved to PECL. (Derick Rethans)
 
+Reflection:
+  . Implement GH-12908 (Show attribute name/class in ReflectionAttribute dump).
+    (nielsdos)
+
 SimpleXML:
   . Fixed bug GH-12192 (SimpleXML infinite loop when getName() is called
     within foreach). (nielsdos)

UPGRADING

@@ -202,6 +202,10 @@ PDO_SQLITE:
   . Added constant POSIX_SC_CHILD_MAX
   . Added constant POSIX_SC_CLK_TCK
 
+- Reflection:
+  . ReflectionAttribute now contains a $name property to improve the debugging
+    experience.
+
 - SOAP:
   . Added support for clark notation for namespaces in class map.
     It is now possible to specify entries in a class map with clark notation

Zend/tests/attributes/031_backtrace.phpt

@@ -52,7 +52,9 @@ array(2) {
     ["class"]=>
     string(19) "ReflectionAttribute"
     ["object"]=>
-    object(ReflectionAttribute)#2 (0) {
+    object(ReflectionAttribute)#2 (1) {
+      ["name"]=>
+      string(11) "MyAttribute"
     }
     ["type"]=>
     string(2) "->"

ext/reflection/php_reflection.c

@@ -1122,6 +1122,7 @@ static void reflection_attribute_factory(zval *object, HashTable *attributes, ze
 	reference->target = target;
 	intern->ptr = reference;
 	intern->ref_type = REF_TYPE_ATTRIBUTE;
+	ZVAL_STR_COPY(reflection_prop_name(object), data->name);
 }
 /* }}} */
 

ext/reflection/php_reflection.stub.php

@@ -764,6 +764,8 @@ class ReflectionAttribute implements Reflector
     /** @cvalue REFLECTION_ATTRIBUTE_IS_INSTANCEOF */
     public const int IS_INSTANCEOF = UNKNOWN;
 
+    public string $name;
+
     public function getName(): string {}
     public function getTarget(): int {}
     public function isRepeated(): bool {}

ext/reflection/php_reflection_arginfo.h

@@ -0,0 +1,26 @@
+--TEST--
+GH-12908 (Show attribute name/class in ReflectionAttribute dump)
+--FILE--
+<?php
+
+#[\AllowDynamicProperties, \Foo]
+class Test {
+}
+
+print_r((new ReflectionClass(Test::class))->getAttributes());
+
+?>
+--EXPECT--
+Array
+(
+    [0] => ReflectionAttribute Object
+        (
+            [name] => AllowDynamicProperties
+        )
+
+    [1] => ReflectionAttribute Object
+        (
+            [name] => Foo
+        )
+
+)