mb_trim_default_chars set to zend_hash_index_add_new

youkidearitai · youkidearitai · commit 3ad5121769db · 2023-11-23T15:13:01.000+09:00
diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c
@@ -3006,7 +3006,7 @@ static zend_string* mb_trim_default_chars(zend_string *str, mb_trim_mode mode, c
 	zend_hash_init(&what_ht, trim_default_chars_length, NULL, NULL, false);
 
 	for (size_t i = 0; i < trim_default_chars_length; i++) {
-		zend_hash_index_add(&what_ht, trim_default_chars[i], &val);
+		zend_hash_index_add_new(&what_ht, trim_default_chars[i], &val);
 	}
 	zend_string* retval = trim_each_wchar(str, &what_ht, mode, enc);
 	zend_hash_destroy(&what_ht);

Original file line number	Diff line number	Diff line change
`@@ -3006,7 +3006,7 @@ static zend_string* mb_trim_default_chars(zend_string *str, mb_trim_mode mode, c`
`3006`	`3006`	`zend_hash_init(&what_ht, trim_default_chars_length, NULL, NULL, false);`
`3007`	`3007`
`3008`	`3008`	`for (size_t i = 0; i < trim_default_chars_length; i++) {`
`3009`		`- zend_hash_index_add(&what_ht, trim_default_chars[i], &val);`
	`3009`	`+ zend_hash_index_add_new(&what_ht, trim_default_chars[i], &val);`
`3010`	`3010`	`}`
`3011`	`3011`	`zend_string* retval = trim_each_wchar(str, &what_ht, mode, enc);`
`3012`	`3012`	`zend_hash_destroy(&what_ht);`