Skip to content

Commit 3a935de

Browse files
kocsismatekocsismate
committed
Declare ext/reflection constants in stubs
1 parent eff9aed commit 3a935de

File tree

3 files changed

+239
-29
lines changed

3 files changed

+239
-29
lines changed

‎ext/reflection/php_reflection.c

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7135,8 +7135,6 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
71357135
reflection_function_ptr = register_class_ReflectionFunction(reflection_function_abstract_ptr);
71367136
reflection_function_ptr->create_object = reflection_objects_new;
71377137

7138-
REGISTER_REFLECTION_CLASS_CONST_LONG(function, "IS_DEPRECATED", ZEND_ACC_DEPRECATED);
7139-
71407138
reflection_generator_ptr = register_class_ReflectionGenerator();
71417139
reflection_generator_ptr->create_object = reflection_objects_new;
71427140

@@ -7158,42 +7156,18 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
71587156
reflection_method_ptr = register_class_ReflectionMethod(reflection_function_abstract_ptr);
71597157
reflection_method_ptr->create_object = reflection_objects_new;
71607158

7161-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_STATIC", ZEND_ACC_STATIC);
7162-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_PUBLIC", ZEND_ACC_PUBLIC);
7163-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_PROTECTED", ZEND_ACC_PROTECTED);
7164-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_PRIVATE", ZEND_ACC_PRIVATE);
7165-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_ABSTRACT", ZEND_ACC_ABSTRACT);
7166-
REGISTER_REFLECTION_CLASS_CONST_LONG(method, "IS_FINAL", ZEND_ACC_FINAL);
7167-
71687159
reflection_class_ptr = register_class_ReflectionClass(reflector_ptr);
71697160
reflection_class_ptr->create_object = reflection_objects_new;
71707161

7171-
/* IS_IMPLICIT_ABSTRACT is not longer used */
7172-
REGISTER_REFLECTION_CLASS_CONST_LONG(class, "IS_IMPLICIT_ABSTRACT", ZEND_ACC_IMPLICIT_ABSTRACT_CLASS);
7173-
REGISTER_REFLECTION_CLASS_CONST_LONG(class, "IS_EXPLICIT_ABSTRACT", ZEND_ACC_EXPLICIT_ABSTRACT_CLASS);
7174-
REGISTER_REFLECTION_CLASS_CONST_LONG(class, "IS_FINAL", ZEND_ACC_FINAL);
7175-
REGISTER_REFLECTION_CLASS_CONST_LONG(class, "IS_READONLY", ZEND_ACC_READONLY_CLASS);
7176-
71777162
reflection_object_ptr = register_class_ReflectionObject(reflection_class_ptr);
71787163
reflection_object_ptr->create_object = reflection_objects_new;
71797164

71807165
reflection_property_ptr = register_class_ReflectionProperty(reflector_ptr);
71817166
reflection_property_ptr->create_object = reflection_objects_new;
71827167

7183-
REGISTER_REFLECTION_CLASS_CONST_LONG(property, "IS_STATIC", ZEND_ACC_STATIC);
7184-
REGISTER_REFLECTION_CLASS_CONST_LONG(property, "IS_READONLY", ZEND_ACC_READONLY);
7185-
REGISTER_REFLECTION_CLASS_CONST_LONG(property, "IS_PUBLIC", ZEND_ACC_PUBLIC);
7186-
REGISTER_REFLECTION_CLASS_CONST_LONG(property, "IS_PROTECTED", ZEND_ACC_PROTECTED);
7187-
REGISTER_REFLECTION_CLASS_CONST_LONG(property, "IS_PRIVATE", ZEND_ACC_PRIVATE);
7188-
71897168
reflection_class_constant_ptr = register_class_ReflectionClassConstant(reflector_ptr);
71907169
reflection_class_constant_ptr->create_object = reflection_objects_new;
71917170

7192-
REGISTER_REFLECTION_CLASS_CONST_LONG(class_constant, "IS_PUBLIC", ZEND_ACC_PUBLIC);
7193-
REGISTER_REFLECTION_CLASS_CONST_LONG(class_constant, "IS_PROTECTED", ZEND_ACC_PROTECTED);
7194-
REGISTER_REFLECTION_CLASS_CONST_LONG(class_constant, "IS_PRIVATE", ZEND_ACC_PRIVATE);
7195-
REGISTER_REFLECTION_CLASS_CONST_LONG(class_constant, "IS_FINAL", ZEND_ACC_FINAL);
7196-
71977171
reflection_extension_ptr = register_class_ReflectionExtension(reflector_ptr);
71987172
reflection_extension_ptr->create_object = reflection_objects_new;
71997173

@@ -7218,8 +7192,6 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
72187192
reflection_fiber_ptr = register_class_ReflectionFiber();
72197193
reflection_fiber_ptr->create_object = reflection_objects_new;
72207194

7221-
REGISTER_REFLECTION_CLASS_CONST_LONG(attribute, "IS_INSTANCEOF", REFLECTION_ATTRIBUTE_IS_INSTANCEOF);
7222-
72237195
REFLECTION_G(key_initialized) = 0;
72247196

72257197
return SUCCESS;

‎ext/reflection/php_reflection.stub.php

Lines changed: 112 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,12 @@ public function getAttributes(?string $name = null, int $flags = 0): array {}
113113

114114
class ReflectionFunction extends ReflectionFunctionAbstract
115115
{
116+
/**
117+
* @var int
118+
* @cvalue ZEND_ACC_DEPRECATED
119+
*/
120+
public const IS_DEPRECATED = UNKNOWN;
121+
116122
public function __construct(Closure|string $function) {}
117123

118124
public function __toString(): string {}
@@ -161,6 +167,37 @@ public function getExecutingGenerator(): Generator {}
161167

162168
class ReflectionMethod extends ReflectionFunctionAbstract
163169
{
170+
/**
171+
* @var int
172+
* @cvalue ZEND_ACC_STATIC
173+
*/
174+
public const IS_STATIC = UNKNOWN;
175+
/**
176+
* @var int
177+
* @cvalue ZEND_ACC_PUBLIC
178+
*/
179+
public const IS_PUBLIC = UNKNOWN;
180+
/**
181+
* @var int
182+
* @cvalue ZEND_ACC_PROTECTED
183+
*/
184+
public const IS_PROTECTED = UNKNOWN;
185+
/**
186+
* @var int
187+
* @cvalue ZEND_ACC_PRIVATE
188+
*/
189+
public const IS_PRIVATE = UNKNOWN;
190+
/**
191+
* @var int
192+
* @cvalue ZEND_ACC_ABSTRACT
193+
*/
194+
public const IS_ABSTRACT = UNKNOWN;
195+
/**
196+
* @var int
197+
* @cvalue ZEND_ACC_FINAL
198+
*/
199+
public const IS_FINAL = UNKNOWN;
200+
164201
public string $class;
165202

166203
public function __construct(object|string $objectOrMethod, ?string $method = null) {}
@@ -215,6 +252,28 @@ public function setAccessible(bool $accessible): void {}
215252
/** @not-serializable */
216253
class ReflectionClass implements Reflector
217254
{
255+
/**
256+
* @var int
257+
* @cvalue ZEND_ACC_IMPLICIT_ABSTRACT_CLASS
258+
* @todo deprecate
259+
*/
260+
public const IS_IMPLICIT_ABSTRACT = UNKNOWN;
261+
/**
262+
* @var int
263+
* @cvalue ZEND_ACC_EXPLICIT_ABSTRACT_CLASS
264+
*/
265+
public const IS_EXPLICIT_ABSTRACT = UNKNOWN;
266+
/**
267+
* @var int
268+
* @cvalue ZEND_ACC_FINAL
269+
*/
270+
public const IS_FINAL = UNKNOWN;
271+
/**
272+
* @var int
273+
* @cvalue ZEND_ACC_READONLY_CLASS
274+
*/
275+
public const IS_READONLY = UNKNOWN;
276+
218277
public string $name;
219278

220279
private function __clone(): void {}
@@ -391,6 +450,32 @@ public function __construct(object $object) {}
391450
/** @not-serializable */
392451
class ReflectionProperty implements Reflector
393452
{
453+
/**
454+
* @var int
455+
* @cvalue ZEND_ACC_STATIC
456+
*/
457+
public const IS_STATIC = UNKNOWN;
458+
/**
459+
* @var int
460+
* @cvalue ZEND_ACC_READONLY_CLASS
461+
*/
462+
public const IS_READONLY = UNKNOWN;
463+
/**
464+
* @var int
465+
* @cvalue ZEND_ACC_PUBLIC
466+
*/
467+
public const IS_PUBLIC = UNKNOWN;
468+
/**
469+
* @var int
470+
* @cvalue ZEND_ACC_PROTECTED
471+
*/
472+
public const IS_PROTECTED = UNKNOWN;
473+
/**
474+
* @var int
475+
* @cvalue ZEND_ACC_PRIVATE
476+
*/
477+
public const IS_PRIVATE = UNKNOWN;
478+
394479
public string $name;
395480
public string $class;
396481

@@ -461,6 +546,27 @@ public function getAttributes(?string $name = null, int $flags = 0): array {}
461546
/** @not-serializable */
462547
class ReflectionClassConstant implements Reflector
463548
{
549+
/**
550+
* @var int
551+
* @cvalue ZEND_ACC_PUBLIC
552+
*/
553+
public const IS_PUBLIC = UNKNOWN;
554+
/**
555+
* @var int
556+
* @cvalue ZEND_ACC_PROTECTED
557+
*/
558+
public const IS_PROTECTED = UNKNOWN;
559+
/**
560+
* @var int
561+
* @cvalue ZEND_ACC_PRIVATE
562+
*/
563+
public const IS_PRIVATE = UNKNOWN;
564+
/**
565+
* @var int
566+
* @cvalue ZEND_ACC_FINAL
567+
*/
568+
public const IS_FINAL = UNKNOWN;
569+
464570
public string $name;
465571
public string $class;
466572

@@ -704,6 +810,12 @@ private function __construct() {}
704810
/** @not-serializable */
705811
class ReflectionAttribute implements Reflector
706812
{
813+
/**
814+
* @var int
815+
* @cvalue REFLECTION_ATTRIBUTE_IS_INSTANCEOF
816+
*/
817+
public const IS_INSTANCEOF = UNKNOWN;
818+
707819
public function getName(): string {}
708820
public function getTarget(): int {}
709821
public function isRepeated(): bool {}

‎ext/reflection/php_reflection_arginfo.h

Lines changed: 127 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)