Disable constant propagation for variables that can be modified indirectly

dstogov · dstogov · commit 37ec4e0845a5 · 2017-07-05T19:34:46.000+03:00
diff --git a/ext/opcache/Optimizer/sccp.c b/ext/opcache/Optimizer/sccp.c
@@ -1329,7 +1329,11 @@ static void sccp_context_init(sccp_ctx *ctx,
 		MAKE_BOT(&ctx->values[i]);
 	}
 	for (; i < ssa->vars_count; ++i) {
-		MAKE_TOP(&ctx->values[i]);
+		if (ssa->vars[i].alias) {
+			MAKE_BOT(&ctx->values[i]);
+		} else {
+			MAKE_TOP(&ctx->values[i]);
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1329,7 +1329,11 @@ static void sccp_context_init(sccp_ctx *ctx,`
`1329`	`1329`	`MAKE_BOT(&ctx->values[i]);`
`1330`	`1330`	`}`
`1331`	`1331`	`for (; i < ssa->vars_count; ++i) {`
`1332`		`- MAKE_TOP(&ctx->values[i]);`
	`1332`	`+ if (ssa->vars[i].alias) {`
	`1333`	`+ MAKE_BOT(&ctx->values[i]);`
	`1334`	`+ } else {`
	`1335`	`+ MAKE_TOP(&ctx->values[i]);`
	`1336`	`+ }`
`1333`	`1337`	`}`
`1334`	`1338`	`}`
`1335`	`1339`