Skip to content

Commit 36c90c3

Browse files
committed
[W.I.P] ext/mbstring: Add some TODO
1 parent 35e926b commit 36c90c3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

ext/mbstring/mbstring.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,7 @@ static void _php_mb_free_regex(void *opaque)
538538
}
539539
/* }}} */
540540

541+
// TODO make void as return value is ignored?
541542
/* {{{ php_mb_nls_get_default_detect_order_list */
542543
static int php_mb_nls_get_default_detect_order_list(enum mbfl_no_language lang, enum mbfl_no_encoding **plist, size_t *plist_size)
543544
{
@@ -858,6 +859,7 @@ static PHP_INI_MH(OnUpdate_mbstring_substitute_character)
858859
MBSTRG(filter_illegal_substchar) = c;
859860
MBSTRG(current_filter_illegal_substchar) = c;
860861
}
862+
// TODO Warn about invalid character?
861863
}
862864
}
863865
} else {

0 commit comments

Comments
 (0)