Fixed bug #63757 (getenv() produces memory leak with CGI SAPI)

dstogov · dstogov · commit 35f86d24d81b · 2012-12-13T13:39:42.000+04:00
diff --git a/NEWS b/NEWS
@@ -2,6 +2,9 @@ PHP                                                                        NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 2012, PHP 5.4.11
 
+- Filter:
+  . Fixed bug #63757 (getenv() produces memory leak with CGI SAPI). (Dmitry)
+
 - JSON:
   . Fixed bug #63737 (json_decode does not properly decode with options
     parameter). (Adam)
diff --git a/main/SAPI.c b/main/SAPI.c
@@ -1017,7 +1017,7 @@ SAPI_API char *sapi_getenv(char *name, size_t name_len TSRMLS_DC)
 			return NULL;
 		}
 		if (sapi_module.input_filter) {
-			sapi_module.input_filter(PARSE_ENV, name, &value, strlen(value), NULL TSRMLS_CC);
+			sapi_module.input_filter(PARSE_STRING, name, &value, strlen(value), NULL TSRMLS_CC);
 		}
 		return value;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1017,7 +1017,7 @@ SAPI_API char sapi_getenv(char name, size_t name_len TSRMLS_DC)`
`1017`	`1017`	`return NULL;`
`1018`	`1018`	`}`
`1019`	`1019`	`if (sapi_module.input_filter) {`
`1020`		`- sapi_module.input_filter(PARSE_ENV, name, &value, strlen(value), NULL TSRMLS_CC);`
	`1020`	`+ sapi_module.input_filter(PARSE_STRING, name, &value, strlen(value), NULL TSRMLS_CC);`
`1021`	`1021`	`}`
`1022`	`1022`	`return value;`
`1023`	`1023`	`}`