Skip to content

Commit 353d4ce

Browse files
authored
ext/xmlreader: Add class constant types to stub (#13596)
Declares class constant types for the `XMLReader` class.
1 parent 013978e commit 353d4ce

File tree

3 files changed

+48
-67
lines changed

3 files changed

+48
-67
lines changed

UPGRADING

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,9 @@ PHP 8.4 UPGRADE NOTES
481481
- Sqlite:
482482
. The class constants are typed now.
483483

484+
- XMLReader:
485+
. The class constants are typed now.
486+
484487
- XSL:
485488
. The typed properties XSLTProcessor::$cloneDocument and
486489
XSLTProcessor::$doXInclude are now declared.

ext/xmlreader/php_xmlreader.stub.php

Lines changed: 22 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -7,118 +7,96 @@ class XMLReader
77
/* Constants for NodeType - cannot define common types to share with dom as there are differences in these types */
88

99
/**
10-
* @var int
1110
* @cvalue XML_READER_TYPE_NONE
1211
*/
13-
public const NONE = UNKNOWN;
12+
public const int NONE = UNKNOWN;
1413
/**
15-
* @var int
1614
* @cvalue XML_READER_TYPE_ELEMENT
1715
*/
18-
public const ELEMENT = UNKNOWN;
16+
public const int ELEMENT = UNKNOWN;
1917
/**
20-
* @var int
2118
* @cvalue XML_READER_TYPE_ATTRIBUTE
2219
*/
23-
public const ATTRIBUTE = UNKNOWN;
20+
public const int ATTRIBUTE = UNKNOWN;
2421
/**
25-
* @var int
2622
* @cvalue XML_READER_TYPE_TEXT
2723
*/
28-
public const TEXT = UNKNOWN;
24+
public const int TEXT = UNKNOWN;
2925
/**
30-
* @var int
3126
* @cvalue XML_READER_TYPE_CDATA
3227
*/
33-
public const CDATA = UNKNOWN;
28+
public const int CDATA = UNKNOWN;
3429
/**
35-
* @var int
3630
* @cvalue XML_READER_TYPE_ENTITY_REFERENCE
3731
*/
38-
public const ENTITY_REF = UNKNOWN;
32+
public const int ENTITY_REF = UNKNOWN;
3933
/**
40-
* @var int
4134
* @cvalue XML_READER_TYPE_ENTITY
4235
*/
43-
public const ENTITY = UNKNOWN;
36+
public const int ENTITY = UNKNOWN;
4437
/**
45-
* @var int
4638
* @cvalue XML_READER_TYPE_PROCESSING_INSTRUCTION
4739
*/
48-
public const PI = UNKNOWN;
40+
public const int PI = UNKNOWN;
4941
/**
50-
* @var int
5142
* @cvalue XML_READER_TYPE_COMMENT
5243
*/
53-
public const COMMENT = UNKNOWN;
44+
public const int COMMENT = UNKNOWN;
5445
/**
55-
* @var int
5646
* @cvalue XML_READER_TYPE_DOCUMENT
5747
*/
58-
public const DOC = UNKNOWN;
48+
public const int DOC = UNKNOWN;
5949
/**
60-
* @var int
6150
* @cvalue XML_READER_TYPE_DOCUMENT_TYPE
6251
*/
63-
public const DOC_TYPE = UNKNOWN;
52+
public const int DOC_TYPE = UNKNOWN;
6453
/**
65-
* @var int
6654
* @cvalue XML_READER_TYPE_DOCUMENT_FRAGMENT
6755
*/
68-
public const DOC_FRAGMENT = UNKNOWN;
56+
public const int DOC_FRAGMENT = UNKNOWN;
6957
/**
70-
* @var int
7158
* @cvalue XML_READER_TYPE_NOTATION
7259
*/
73-
public const NOTATION = UNKNOWN;
60+
public const int NOTATION = UNKNOWN;
7461
/**
75-
* @var int
7662
* @cvalue XML_READER_TYPE_WHITESPACE
7763
*/
78-
public const WHITESPACE = UNKNOWN;
64+
public const int WHITESPACE = UNKNOWN;
7965
/**
80-
* @var int
8166
* @cvalue XML_READER_TYPE_SIGNIFICANT_WHITESPACE
8267
*/
83-
public const SIGNIFICANT_WHITESPACE = UNKNOWN;
68+
public const int SIGNIFICANT_WHITESPACE = UNKNOWN;
8469
/**
85-
* @var int
8670
* @cvalue XML_READER_TYPE_END_ELEMENT
8771
*/
88-
public const END_ELEMENT = UNKNOWN;
72+
public const int END_ELEMENT = UNKNOWN;
8973
/**
90-
* @var int
9174
* @cvalue XML_READER_TYPE_END_ENTITY
9275
*/
93-
public const END_ENTITY = UNKNOWN;
76+
public const int END_ENTITY = UNKNOWN;
9477
/**
95-
* @var int
9678
* @cvalue XML_READER_TYPE_XML_DECLARATION
9779
*/
98-
public const XML_DECLARATION = UNKNOWN;
80+
public const int XML_DECLARATION = UNKNOWN;
9981

10082
/* Constants for Parser options */
10183

10284
/**
103-
* @var int
10485
* @cvalue XML_PARSER_LOADDTD
10586
*/
106-
public const LOADDTD = UNKNOWN;
87+
public const int LOADDTD = UNKNOWN;
10788
/**
108-
* @var int
10989
* @cvalue XML_PARSER_DEFAULTATTRS
11090
*/
111-
public const DEFAULTATTRS = UNKNOWN;
91+
public const int DEFAULTATTRS = UNKNOWN;
11292
/**
113-
* @var int
11493
* @cvalue XML_PARSER_VALIDATE
11594
*/
116-
public const VALIDATE = UNKNOWN;
95+
public const int VALIDATE = UNKNOWN;
11796
/**
118-
* @var int
11997
* @cvalue XML_PARSER_SUBST_ENTITIES
12098
*/
121-
public const SUBST_ENTITIES = UNKNOWN;
99+
public const int SUBST_ENTITIES = UNKNOWN;
122100

123101

124102
public int $attributeCount;

ext/xmlreader/php_xmlreader_arginfo.h

Lines changed: 23 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)