Sync HAVE_OPENSSL* symbols

This syncs few inconsistencies between the Windows and Autotools build
systems:
- HAVE_OPENSSL_EXT is now defined in the same style on both systems
  (undefined - extension is not available, defined to 1 - extension is
  available)
- HAVE_OPENSSL removed as it was only defined on Windows

Author: petk

UPGRADING.INTERNALS

@@ -152,6 +152,9 @@ PHP 8.4 INTERNALS UPGRADE NOTES
    - Unused symbols CONFIGURATION_FILE_PATH, DISCARD_PATH, HAVE_ERRMSG_H,
      HAVE_REGCOMP, HAVE_RINT, NEED_ISBLANK, PHP_URL_FOPEN, REGEX, HSREGEX,
      USE_CONFIG_FILE have been removed.
+   - The HAVE_OPENSSL symbol has been removed.
+   - The HAVE_OPENSSL_EXT symbol is now consistently defined to value 1 whether
+     the openssl extension is available either as shared or built statically.
 
 ========================
 3. Module changes

ext/openssl/config.w32

@@ -7,7 +7,6 @@ if (PHP_OPENSSL != "no") {
 
 	if (ret > 0) {
 		EXTENSION("openssl", "openssl.c xp_ssl.c");
-		AC_DEFINE("HAVE_OPENSSL_EXT", PHP_OPENSSL_SHARED ? 0 : 1, "Have openssl");
-		AC_DEFINE("HAVE_OPENSSL", 1);
+		AC_DEFINE("HAVE_OPENSSL_EXT", 1, "Whether the openssl extension is available.");
 	}
 }

ext/openssl/config0.m4

@@ -22,7 +22,7 @@ if test "$PHP_OPENSSL" != "no"; then
   PHP_SUBST(OPENSSL_SHARED_LIBADD)
   PHP_SETUP_OPENSSL(OPENSSL_SHARED_LIBADD,
   [
-    AC_DEFINE(HAVE_OPENSSL_EXT,1,[ ])
+    AC_DEFINE([HAVE_OPENSSL_EXT], [1], [Whether the openssl extension is available.])
   ], [
     AC_MSG_ERROR([OpenSSL check failed. Please check config.log for more information.])
   ])

ext/openssl/php_openssl.h

@@ -17,7 +17,7 @@
 
 #ifndef PHP_OPENSSL_H
 #define PHP_OPENSSL_H
-/* HAVE_OPENSSL would include SSL MySQL stuff */
+
 #ifdef HAVE_OPENSSL_EXT
 extern zend_module_entry openssl_module_entry;
 #define phpext_openssl_ptr &openssl_module_entry

sapi/cgi/cgi_main.c

@@ -87,7 +87,7 @@ int __riscosify_control = __RISCOSIFY_STRICT_UNIX_SPECS;
 #include "fastcgi.h"
 #include "cgi_main_arginfo.h"
 
-#if defined(PHP_WIN32) && defined(HAVE_OPENSSL)
+#if defined(PHP_WIN32) && defined(HAVE_OPENSSL_EXT)
 # include "openssl/applink.c"
 #endif
 

sapi/cli/php_cli.c

@@ -88,7 +88,7 @@
 # include "win32/select.h"
 #endif
 
-#if defined(PHP_WIN32) && defined(HAVE_OPENSSL)
+#if defined(PHP_WIN32) && defined(HAVE_OPENSSL_EXT)
 # include "openssl/applink.c"
 #endif
 

sapi/phpdbg/phpdbg.c

@@ -33,7 +33,7 @@
 
 #include "ext/standard/basic_functions.h"
 
-#if defined(PHP_WIN32) && defined(HAVE_OPENSSL)
+#if defined(PHP_WIN32) && defined(HAVE_OPENSSL_EXT)
 # include "openssl/applink.c"
 #endif