pgsqlSetNoticeCallback: cleanup on pgsql_handle_closer

outtersg · outtersg · commit 33a3ac167eef · 2020-01-09T20:29:13.000+01:00
Fix to what @ranvis noticed in #4823 (comment)
diff --git a/ext/pdo_pgsql/pgsql_driver.c b/ext/pdo_pgsql/pgsql_driver.c
@@ -225,6 +225,7 @@ static int pgsql_handle_closer(pdo_dbh_t *dbh) /* {{{ */
 {
 	pdo_pgsql_db_handle *H = (pdo_pgsql_db_handle *)dbh->driver_data;
 	if (H) {
+		pdo_pgsql_cleanup_notice_callback(H);
 		if (H->server) {
 			PQfinish(H->server);
 			H->server = NULL;

Original file line number	Diff line number	Diff line change
`@@ -225,6 +225,7 @@ static int pgsql_handle_closer(pdo_dbh_t dbh) / {{{ */`
`225`	`225`	`{`
`226`	`226`	`pdo_pgsql_db_handle H = (pdo_pgsql_db_handle )dbh->driver_data;`
`227`	`227`	`if (H) {`
	`228`	`+ pdo_pgsql_cleanup_notice_callback(H);`
`228`	`229`	`if (H->server) {`
`229`	`230`	`PQfinish(H->server);`
`230`	`231`	`H->server = NULL;`