Avoid accessing undefined variables in run-tests.php

The $php_cgi and $phpdbg cases here are definitely real bugs, and
caused the script to bail out under certain ini settings.

The other paths may actually be unreachable in practice, but were
highlighted by PhpStorm.

Writing to php://stdin apparently works fine, but doesn't make any
sense, and was probably a mistake due to bad variable naming.

Author: IMSoP

run-tests.php

@@ -935,8 +935,12 @@ function save_or_mail_results(): void
            $PHP_FAILED_TESTS, $php, $output_file;
 
     /* We got failed Tests, offer the user to send an e-mail to QA team, unless NO_INTERACTION is set */
-    if (!getenv('NO_INTERACTION') && !TRAVIS_CI) {
-        $fp = fopen("php://stdin", "r+");
+    if (getenv('NO_INTERACTION') || TRAVIS_CI) {
+        $stdin = null;
+        $user_input = '';
+    }
+    else {
+        $stdin = fopen("php://stdin", "r");
         if ($sum_results['FAILED'] || $sum_results['BORKED'] || $sum_results['WARNED'] || $sum_results['LEAKED']) {
             echo "\nYou may have found a problem in PHP.";
         }
@@ -948,7 +952,7 @@ function save_or_mail_results(): void
         echo "Do you want to send this report now? [Yns]: ";
         flush();
 
-        $user_input = fgets($fp, 10);
+        $user_input = fgets($stdin, 10);
         $just_save_results = (!empty($user_input) && strtolower($user_input[0]) === 's');
     }
 
@@ -967,10 +971,12 @@ function save_or_mail_results(): void
             /* Ask the user to provide an email address, so that QA team can contact the user */
             if (TRAVIS_CI) {
                 $user_email = 'travis at php dot net';
+            } elseif ($stdin === null) {
+                $user_email = null;
             } elseif (!strncasecmp($user_input, 'y', 1) || strlen(trim($user_input)) == 0) {
                 echo "\nPlease enter your email address.\n(Your address will be mangled so that it will not go out on any\nmailinglist in plain text): ";
                 flush();
-                $user_email = trim(fgets($fp, 1024));
+                $user_email = trim(fgets($stdin, 1024));
                 $user_email = str_replace("@", " at ", str_replace(".", " dot ", $user_email));
             }
 
@@ -1052,8 +1058,8 @@ function save_or_mail_results(): void
 
                 echo "Please send " . $output_file . " to " . PHP_QA_EMAIL . " manually, thank you.\n";
             } elseif (!getenv('NO_INTERACTION') && !TRAVIS_CI) {
-                fwrite($fp, "\nThank you for helping to make PHP better.\n");
-                fclose($fp);
+                echo "\nThank you for helping to make PHP better.\n";
+                fclose($stdin);
             }
         }
     }
@@ -1887,13 +1893,8 @@ function run_test(string $php, $file, array $env): string
     $org_file = $file;
     $orig_php = $php;
 
-    if (isset($env['TEST_PHP_CGI_EXECUTABLE'])) {
-        $php_cgi = $env['TEST_PHP_CGI_EXECUTABLE'];
-    }
-
-    if (isset($env['TEST_PHPDBG_EXECUTABLE'])) {
-        $phpdbg = $env['TEST_PHPDBG_EXECUTABLE'];
-    }
+    $php_cgi = $env['TEST_PHP_CGI_EXECUTABLE'] ?? null;
+    $phpdbg = $env['TEST_PHPDBG_EXECUTABLE'] ?? null;
 
     if (is_array($file)) {
         $file = $file[0];
@@ -2574,6 +2575,8 @@ function run_test(string $php, $file, array $env): string
         }
     }
 
+    $wanted_headers = null;
+    $output_headers = null;
     $failed_headers = false;
 
     if ($test->hasSection('EXPECTHEADERS')) {
@@ -2732,6 +2735,8 @@ function run_test(string $php, $file, array $env): string
         }
     }
 
+    $restype = [];
+
     if ($leaked) {
         $restype[] = $test->hasSection('XLEAK') ?
                         'XLEAK' : 'LEAK';