Fix bug in str_ends_with

wkhudgins92 · wkhudgins92 · commit 31ba8251e378 · 2020-03-31T18:48:47.000-05:00
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -1899,7 +1899,7 @@ PHP_FUNCTION(str_ends_with) {
     }
 
     k = ZSTR_LEN(haystack) - ZSTR_LEN(needle);
-    RETURN_BOOL(memcmp(&(ZSTR_VAL(haystack))[k], &(ZSTR_VAL(needle))[k], ZSTR_LEN(needle)) == 0);
+    RETURN_BOOL(memcmp(&(ZSTR_VAL(haystack))[k], ZSTR_VAL(needle), ZSTR_LEN(needle)) == 0);
 }
 
 /* {{{ proto string strchr(string haystack, string needle)

Original file line number	Diff line number	Diff line change
`@@ -1899,7 +1899,7 @@ PHP_FUNCTION(str_ends_with) {`
`1899`	`1899`	`}`
`1900`	`1900`
`1901`	`1901`	`k = ZSTR_LEN(haystack) - ZSTR_LEN(needle);`
`1902`		`- RETURN_BOOL(memcmp(&(ZSTR_VAL(haystack))[k], &(ZSTR_VAL(needle))[k], ZSTR_LEN(needle)) == 0);`
	`1902`	`+ RETURN_BOOL(memcmp(&(ZSTR_VAL(haystack))[k], ZSTR_VAL(needle), ZSTR_LEN(needle)) == 0);`
`1903`	`1903`	`}`
`1904`	`1904`
`1905`	`1905`	`/* {{{ proto string strchr(string haystack, string needle)`