Skip to content

Commit 315f205

Browse files
committed
Remove dead check in pcre
This isn't reachable since ab32d36, because since then the library itself checks this condition during compilation. The compilation failure that results of it makes this code not reachable. This is split off of GH-14424.
1 parent 6a14730 commit 315f205

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

ext/pcre/php_pcre.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -550,11 +550,6 @@ static zend_string **make_subpats_table(uint32_t num_subpats, pcre_cache_entry *
550550
unsigned short name_idx = 0x100 * (unsigned char)name_table[0] + (unsigned char)name_table[1];
551551
const char *name = name_table + 2;
552552
subpat_names[name_idx] = zend_string_init(name, strlen(name), 0);
553-
if (is_numeric_string(ZSTR_VAL(subpat_names[name_idx]), ZSTR_LEN(subpat_names[name_idx]), NULL, NULL, 0) > 0) {
554-
php_error_docref(NULL, E_WARNING, "Numeric named subpatterns are not allowed");
555-
free_subpats_table(subpat_names, num_subpats);
556-
return NULL;
557-
}
558553
name_table += name_size;
559554
}
560555
return subpat_names;

0 commit comments

Comments
 (0)