Skip to content

Commit 312b729

Browse files
committed
Convert some instanceof checks to assertions
Again, $this must be instanceof self.
1 parent 2c0b4c8 commit 312b729

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ext/mysqli/mysqli_nonapi.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ void mysqli_common_connect(INTERNAL_FUNCTION_PARAMETERS, bool is_real_connect, b
8686
RETURN_THROWS();
8787
}
8888

89-
if (object && instanceof_function(Z_OBJCE_P(object), mysqli_link_class_entry)) {
89+
if (object) {
90+
ZEND_ASSERT(instanceof_function(Z_OBJCE_P(object), mysqli_link_class_entry));
9091
mysqli_resource = (Z_MYSQLI_P(object))->ptr;
9192
if (mysqli_resource && mysqli_resource->ptr) {
9293
mysql = (MY_MYSQL*) mysqli_resource->ptr;
@@ -354,9 +355,10 @@ void mysqli_common_connect(INTERNAL_FUNCTION_PARAMETERS, bool is_real_connect, b
354355

355356
mysql->multi_query = 0;
356357

357-
if (!object || !instanceof_function(Z_OBJCE_P(object), mysqli_link_class_entry)) {
358+
if (!object) {
358359
MYSQLI_RETURN_RESOURCE(mysqli_resource, mysqli_link_class_entry);
359360
} else {
361+
ZEND_ASSERT(instanceof_function(Z_OBJCE_P(object), mysqli_link_class_entry));
360362
(Z_MYSQLI_P(object))->ptr = mysqli_resource;
361363
}
362364
if (!is_real_connect) {

0 commit comments

Comments
 (0)