Skip to content

Commit 2fa3e80

Browse files
committed
ext/pcntl: Fix [-Wsign-compare] warnings
1 parent 6725398 commit 2fa3e80

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

ext/pcntl/pcntl.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -714,8 +714,7 @@ PHP_FUNCTION(pcntl_signal)
714714
if (!PCNTL_G(spares)) {
715715
/* since calling malloc() from within a signal handler is not portable,
716716
* pre-allocate a few records for recording signals */
717-
int i;
718-
for (i = 0; i < PCNTL_G(num_signals); i++) {
717+
for (unsigned int i = 0; i < PCNTL_G(num_signals); i++) {
719718
struct php_pcntl_pending_signal *psig;
720719

721720
psig = emalloc(sizeof(*psig));
@@ -903,7 +902,7 @@ PHP_FUNCTION(pcntl_sigprocmask)
903902
RETURN_THROWS();
904903
}
905904

906-
for (int signal_no = 1; signal_no < PCNTL_G(num_signals); ++signal_no) {
905+
for (unsigned int signal_no = 1; signal_no < PCNTL_G(num_signals); ++signal_no) {
907906
if (sigismember(&old_set, signal_no) != 1) {
908907
continue;
909908
}
@@ -1656,7 +1655,7 @@ PHP_FUNCTION(pcntl_setcpuaffinity)
16561655

16571656
// 0 == getpid in this context, we're just saving a syscall
16581657
pid = pid_is_null ? 0 : pid;
1659-
zend_ulong maxcpus = (zend_ulong)sysconf(_SC_NPROCESSORS_CONF);
1658+
zend_long maxcpus = sysconf(_SC_NPROCESSORS_CONF);
16601659
PCNTL_CPU_ZERO(mask);
16611660

16621661
ZEND_HASH_FOREACH_VAL(Z_ARRVAL_P(hmask), ncpu) {

0 commit comments

Comments
 (0)