Promote warning about length larger than buffer size

Girgias · Girgias · commit 2f20f988b8c4 · 2020-09-13T23:44:59.000+02:00
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -2637,9 +2637,8 @@ PHP_FUNCTION(pg_lo_write)
 			RETURN_THROWS();
 		}
 		if (z_len > (zend_long)str_len) {
-			/* TODO Promote to ValueError? */
-			php_error_docref(NULL, E_WARNING, "Cannot write more than buffer size %zu. Tried to write " ZEND_LONG_FMT, str_len, z_len);
-			RETURN_FALSE;
+			zend_argument_value_error(3, "must be less than or equal to the length of argument #2 ($buf)");
+			RETURN_THROWS();
 		}
 		len = z_len;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2637,9 +2637,8 @@ PHP_FUNCTION(pg_lo_write)`
`2637`	`2637`	`RETURN_THROWS();`
`2638`	`2638`	`}`
`2639`	`2639`	`if (z_len > (zend_long)str_len) {`
`2640`		`- /* TODO Promote to ValueError? */`
`2641`		`- php_error_docref(NULL, E_WARNING, "Cannot write more than buffer size %zu. Tried to write " ZEND_LONG_FMT, str_len, z_len);`
`2642`		`- RETURN_FALSE;`
	`2640`	`+ zend_argument_value_error(3, "must be less than or equal to the length of argument #2 ($buf)");`
	`2641`	`+ RETURN_THROWS();`
`2643`	`2642`	`}`
`2644`	`2643`	`len = z_len;`
`2645`	`2644`	`}`