Skip to content

Commit 2ecc597

Browse files
committed
Removed already implemented TODO comment
1 parent 62f05ac commit 2ecc597

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

ext/opcache/jit/zend_jit_trace.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3591,17 +3591,18 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
35913591
goto jit_failure;
35923592
}
35933593
for (j = 0 ; j < op_array->last_var; j++) {
3594+
uint32_t info;
3595+
zend_uchar type;
3596+
35943597
if (opline->op1_type == IS_CV
35953598
&& EX_VAR_TO_NUM(opline->op1.var) == j
35963599
&& !(op1_info & MAY_BE_REF)
35973600
&& JIT_G(current_frame)
35983601
&& TRACE_FRAME_IS_RETURN_VALUE_USED(JIT_G(current_frame))) {
35993602
continue;
36003603
}
3601-
// TODO: get info from trace ???
3602-
uint32_t info = zend_ssa_cv_info(opline, op_array, op_array_ssa, j);
3603-
zend_uchar type = STACK_TYPE(stack, j);
3604-
3604+
info = zend_ssa_cv_info(opline, op_array, op_array_ssa, j);
3605+
type = STACK_TYPE(stack, j);
36053606
info = zend_jit_trace_type_to_info_ex(type, info);
36063607
if (info & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF)) {
36073608
if (!zend_jit_free_cv(&dasm_state, opline, op_array, info, j)) {

0 commit comments

Comments
 (0)