Skip to content

Commit 2ea79c0

Browse files
authored
Autotools: Use FPM_EXTRA_LIBS for apparmor library (#14884)
Instead of appending -lapparmor to global LIBS variable, this adds it as needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM invocation. Follow-up of GH-14881
1 parent 3dd0c11 commit 2ea79c0

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

sapi/fpm/config.m4

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,8 @@ if test "$PHP_FPM" != "no"; then
420420
[no],
421421
[no])
422422

423-
PHP_ARG_WITH([fpm-apparmor],,
423+
PHP_ARG_WITH([fpm-apparmor],
424+
[whether to enable AppArmor confinement in PHP-FPM],
424425
[AS_HELP_STRING([--with-fpm-apparmor],
425426
[Support AppArmor confinement through libapparmor])],
426427
[no],
@@ -483,23 +484,23 @@ if test "$PHP_FPM" != "no"; then
483484
LIBS=$LIBS_save
484485
])
485486

486-
if test "x$PHP_FPM_APPARMOR" != "xno" ; then
487-
PKG_CHECK_MODULES([APPARMOR], [libapparmor], [
488-
PHP_EVAL_LIBLINE([$APPARMOR_LIBS])
489-
PHP_EVAL_INCLINE([$APPARMOR_CFLAGS])
490-
],
487+
AS_VAR_IF([PHP_FPM_APPARMOR], [no],, [
488+
PKG_CHECK_MODULES([APPARMOR], [libapparmor],
489+
[PHP_EVAL_INCLINE([$APPARMOR_CFLAGS])],
491490
[AC_CHECK_LIB([apparmor], [aa_change_profile],
492-
[PHP_ADD_LIBRARY([apparmor])],
491+
[APPARMOR_LIBS=-lapparmor],
493492
[AC_MSG_ERROR([libapparmor required but not found.])])])
493+
PHP_EVAL_LIBLINE([$APPARMOR_LIBS], [FPM_EXTRA_LIBS], [yes])
494494
495495
dnl Sanity check.
496-
CFLAGS_save="$CFLAGS"
496+
CFLAGS_save=$CFLAGS
497497
CFLAGS="$INCLUDES $CFLAGS"
498498
AC_CHECK_HEADER([sys/apparmor.h],
499-
[AC_DEFINE([HAVE_APPARMOR], [1], [AppArmor confinement available])],
499+
[AC_DEFINE([HAVE_APPARMOR], [1],
500+
[Define to 1 if AppArmor confinement is available for PHP-FPM.])],
500501
[AC_MSG_ERROR([Required sys/apparmor.h not found.])])
501-
CFLAGS="$CFLAGS_save"
502-
fi
502+
CFLAGS=$CFLAGS_save
503+
])
503504

504505
if test "x$PHP_FPM_SELINUX" != "xno" ; then
505506
PKG_CHECK_MODULES([SELINUX], [libselinux], [

0 commit comments

Comments
 (0)