Don't explicitly set return value on ZPP failure

cmb69 · cmb69 · commit 2d1f371871ef · 2019-08-16T17:54:11.000+02:00
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.
diff --git a/ext/bz2/bz2.c b/ext/bz2/bz2.c
@@ -335,7 +335,7 @@ static PHP_FUNCTION(bzread)
 	zend_string *data;
 
 	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "r|l", &bz, &len)) {
-		RETURN_FALSE;
+		return;
 	}
 
 	php_stream_from_zval(stream, bz);
@@ -535,7 +535,7 @@ static PHP_FUNCTION(bzdecompress)
 	bz_stream bzs;
 
 	if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "s|l", &source, &source_len, &small)) {
-		RETURN_FALSE;
+		return;
 	}
 
 	bzs.bzalloc = NULL;

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ static PHP_FUNCTION(bzread)`
`335`	`335`	`zend_string *data;`
`336`	`336`
`337`	`337`	`if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "r\|l", &bz, &len)) {`
`338`		`- RETURN_FALSE;`
	`338`	`+ return;`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`php_stream_from_zval(stream, bz);`
`@@ -535,7 +535,7 @@ static PHP_FUNCTION(bzdecompress)`
`535`	`535`	`bz_stream bzs;`
`536`	`536`
`537`	`537`	`if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS(), "s\|l", &source, &source_len, &small)) {`
`538`		`- RETURN_FALSE;`
	`538`	`+ return;`
`539`	`539`	`}`
`540`	`540`
`541`	`541`	`bzs.bzalloc = NULL;`