Skip to content

Commit 2a9ea2c

Browse files
authored
Drop FIXME in pcntl_signal_dispatch() (#18633)
1 parent dfff6ac commit 2a9ea2c

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

ext/pcntl/pcntl.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,7 +1356,6 @@ void pcntl_signal_dispatch(void)
13561356
while (queue) {
13571357
if ((handle = zend_hash_index_find(&PCNTL_G(php_signal_table), queue->signo)) != NULL) {
13581358
if (Z_TYPE_P(handle) != IS_LONG) {
1359-
ZVAL_NULL(&retval);
13601359
ZVAL_LONG(&params[0], queue->signo);
13611360
#ifdef HAVE_STRUCT_SIGINFO_T
13621361
array_init(&params[1]);
@@ -1366,7 +1365,6 @@ void pcntl_signal_dispatch(void)
13661365
#endif
13671366

13681367
/* Call php signal handler - Note that we do not report errors, and we ignore the return value */
1369-
/* FIXME: this is probably broken when multiple signals are handled in this while loop (retval) */
13701368
call_user_function(NULL, NULL, handle, &retval, 2, params);
13711369
zval_ptr_dtor(&retval);
13721370
#ifdef HAVE_STRUCT_SIGINFO_T

0 commit comments

Comments
 (0)