Skip to content

Commit 2a6f936

Browse files
TysonAndreTysonAndre
committed
Remove leftover ZEND_CAST code for (unset) cast.
Followup for d74d392 Attempting to require a file with (unset) casts results in an E_COMPILE_ERROR that can't be caught or handled by set_exception_handler/set_error_handler. Also remove the (bool) cast, because the ZEND_BOOL opcode handles that. Remove inference that array -> object cast can throw. It was added in 2a286ad - I don't know how creating an stdClass would throw. (numeric keys, references, etc. don't cause it to throw)
1 parent d21ad4d commit 2a6f936

File tree

4 files changed

+21
-69
lines changed

4 files changed

+21
-69
lines changed

‎Zend/zend_vm_def.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5730,12 +5730,6 @@ ZEND_VM_COLD_CONST_HANDLER(51, ZEND_CAST, CONST|TMP|VAR|CV, ANY, TYPE)
57305730
expr = GET_OP1_ZVAL_PTR(BP_VAR_R);
57315731

57325732
switch (opline->extended_value) {
5733-
case IS_NULL:
5734-
ZVAL_NULL(result);
5735-
break;
5736-
case _IS_BOOL:
5737-
ZVAL_BOOL(result, zend_is_true(expr));
5738-
break;
57395733
case IS_LONG:
57405734
ZVAL_LONG(result, zval_get_long(expr));
57415735
break;
@@ -5789,6 +5783,7 @@ ZEND_VM_COLD_CONST_HANDLER(51, ZEND_CAST, CONST|TMP|VAR|CV, ANY, TYPE)
57895783
}
57905784
}
57915785
} else {
5786+
ZEND_ASSERT(opline->extended_value == IS_OBJECT);
57925787
ZVAL_OBJ(result, zend_objects_new(zend_standard_class_def));
57935788
if (Z_TYPE_P(expr) == IS_ARRAY) {
57945789
ht = zend_symtable_to_proptable(Z_ARR_P(expr));

‎Zend/zend_vm_execute.h

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3882,12 +3882,6 @@ static ZEND_VM_COLD ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_CONST_H
38823882
expr = RT_CONSTANT(opline, opline->op1);
38833883

38843884
switch (opline->extended_value) {
3885-
case IS_NULL:
3886-
ZVAL_NULL(result);
3887-
break;
3888-
case _IS_BOOL:
3889-
ZVAL_BOOL(result, zend_is_true(expr));
3890-
break;
38913885
case IS_LONG:
38923886
ZVAL_LONG(result, zval_get_long(expr));
38933887
break;
@@ -3940,6 +3934,7 @@ static ZEND_VM_COLD ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_CONST_H
39403934
}
39413935
}
39423936
} else {
3937+
ZEND_ASSERT(opline->extended_value == IS_OBJECT);
39433938
ZVAL_OBJ(result, zend_objects_new(zend_standard_class_def));
39443939
if (Z_TYPE_P(expr) == IS_ARRAY) {
39453940
ht = zend_symtable_to_proptable(Z_ARR_P(expr));
@@ -17489,12 +17484,6 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_TMP_HANDLER(ZEND_OPC
1748917484
expr = _get_zval_ptr_tmp(opline->op1.var EXECUTE_DATA_CC);
1749017485

1749117486
switch (opline->extended_value) {
17492-
case IS_NULL:
17493-
ZVAL_NULL(result);
17494-
break;
17495-
case _IS_BOOL:
17496-
ZVAL_BOOL(result, zend_is_true(expr));
17497-
break;
1749817487
case IS_LONG:
1749917488
ZVAL_LONG(result, zval_get_long(expr));
1750017489
break;
@@ -17547,6 +17536,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_TMP_HANDLER(ZEND_OPC
1754717536
}
1754817537
}
1754917538
} else {
17539+
ZEND_ASSERT(opline->extended_value == IS_OBJECT);
1755017540
ZVAL_OBJ(result, zend_objects_new(zend_standard_class_def));
1755117541
if (Z_TYPE_P(expr) == IS_ARRAY) {
1755217542
ht = zend_symtable_to_proptable(Z_ARR_P(expr));
@@ -20150,12 +20140,6 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_VAR_HANDLER(ZEND_OPC
2015020140
expr = _get_zval_ptr_var(opline->op1.var EXECUTE_DATA_CC);
2015120141

2015220142
switch (opline->extended_value) {
20153-
case IS_NULL:
20154-
ZVAL_NULL(result);
20155-
break;
20156-
case _IS_BOOL:
20157-
ZVAL_BOOL(result, zend_is_true(expr));
20158-
break;
2015920143
case IS_LONG:
2016020144
ZVAL_LONG(result, zval_get_long(expr));
2016120145
break;
@@ -20209,6 +20193,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_VAR_HANDLER(ZEND_OPC
2020920193
}
2021020194
}
2021120195
} else {
20196+
ZEND_ASSERT(opline->extended_value == IS_OBJECT);
2021220197
ZVAL_OBJ(result, zend_objects_new(zend_standard_class_def));
2021320198
if (Z_TYPE_P(expr) == IS_ARRAY) {
2021420199
ht = zend_symtable_to_proptable(Z_ARR_P(expr));
@@ -36083,12 +36068,6 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_CV_HANDLER(ZEND_OPCO
3608336068
expr = _get_zval_ptr_cv_BP_VAR_R(opline->op1.var EXECUTE_DATA_CC);
3608436069

3608536070
switch (opline->extended_value) {
36086-
case IS_NULL:
36087-
ZVAL_NULL(result);
36088-
break;
36089-
case _IS_BOOL:
36090-
ZVAL_BOOL(result, zend_is_true(expr));
36091-
break;
3609236071
case IS_LONG:
3609336072
ZVAL_LONG(result, zval_get_long(expr));
3609436073
break;
@@ -36141,6 +36120,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CAST_SPEC_CV_HANDLER(ZEND_OPCO
3614136120
}
3614236121
}
3614336122
} else {
36123+
ZEND_ASSERT(opline->extended_value == IS_OBJECT);
3614436124
ZVAL_OBJ(result, zend_objects_new(zend_standard_class_def));
3614536125
if (Z_TYPE_P(expr) == IS_ARRAY) {
3614636126
ht = zend_symtable_to_proptable(Z_ARR_P(expr));

‎ext/opcache/Optimizer/dce.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ static inline zend_bool may_have_side_effects(
106106
case ZEND_IS_SMALLER:
107107
case ZEND_IS_SMALLER_OR_EQUAL:
108108
case ZEND_CASE:
109+
/* TODO: Can ZEND_CAST throw when converting object to array (in custom handlers for zend_get_properties_for?) */
109110
case ZEND_CAST:
110111
case ZEND_ROPE_INIT:
111112
case ZEND_ROPE_ADD:

‎ext/opcache/Optimizer/zend_inference.c

Lines changed: 15 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,23 +1030,7 @@ int zend_inference_calc_range(const zend_op_array *op_array, zend_ssa *ssa, int
10301030
}
10311031
}
10321032
} else if (ssa->ops[line].result_def == var) {
1033-
if (opline->extended_value == IS_NULL) {
1034-
tmp->min = 0;
1035-
tmp->max = 0;
1036-
return 1;
1037-
} else if (opline->extended_value == _IS_BOOL) {
1038-
if (OP1_HAS_RANGE()) {
1039-
op1_min = OP1_MIN_RANGE();
1040-
op1_max = OP1_MAX_RANGE();
1041-
tmp->min = (op1_min > 0 || op1_max < 0);
1042-
tmp->max = (op1_min != 0 || op1_max != 0);
1043-
return 1;
1044-
} else {
1045-
tmp->min = 0;
1046-
tmp->max = 1;
1047-
return 1;
1048-
}
1049-
} else if (opline->extended_value == IS_LONG) {
1033+
if (opline->extended_value == IS_LONG) {
10501034
if (OP1_HAS_RANGE()) {
10511035
tmp->min = OP1_MIN_RANGE();
10521036
tmp->max = OP1_MAX_RANGE();
@@ -2499,24 +2483,19 @@ static int zend_update_type_info(const zend_op_array *op_array,
24992483
UPDATE_SSA_TYPE(tmp, ssa_ops[i].op1_def);
25002484
COPY_SSA_OBJ_TYPE(ssa_ops[i].op1_use, ssa_ops[i].op1_def);
25012485
}
2502-
tmp = 0;
2503-
if (opline->extended_value == _IS_BOOL) {
2504-
tmp |= MAY_BE_TRUE|MAY_BE_FALSE;
2505-
} else {
2506-
tmp |= 1 << opline->extended_value;
2507-
if (tmp & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE)) {
2508-
if ((tmp & MAY_BE_ANY) == (t1 & MAY_BE_ANY)) {
2509-
tmp |= (t1 & MAY_BE_RC1) | MAY_BE_RCN;
2510-
} else if ((opline->extended_value == IS_ARRAY ||
2511-
opline->extended_value == IS_OBJECT) &&
2512-
(t1 & (MAY_BE_ARRAY|MAY_BE_OBJECT))) {
2513-
tmp |= MAY_BE_RC1 | MAY_BE_RCN;
2514-
} else if (opline->extended_value == IS_STRING &&
2515-
(t1 & (MAY_BE_STRING|MAY_BE_OBJECT))) {
2486+
tmp = 1 << opline->extended_value;
2487+
if (tmp & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE)) {
2488+
if ((tmp & MAY_BE_ANY) == (t1 & MAY_BE_ANY)) {
2489+
tmp |= (t1 & MAY_BE_RC1) | MAY_BE_RCN;
2490+
} else if ((opline->extended_value == IS_ARRAY ||
2491+
opline->extended_value == IS_OBJECT) &&
2492+
(t1 & (MAY_BE_ARRAY|MAY_BE_OBJECT))) {
25162493
tmp |= MAY_BE_RC1 | MAY_BE_RCN;
2517-
} else {
2518-
tmp |= MAY_BE_RC1;
2519-
}
2494+
} else if (opline->extended_value == IS_STRING &&
2495+
(t1 & (MAY_BE_STRING|MAY_BE_OBJECT))) {
2496+
tmp |= MAY_BE_RC1 | MAY_BE_RCN;
2497+
} else {
2498+
tmp |= MAY_BE_RC1;
25202499
}
25212500
}
25222501
if (opline->extended_value == IS_ARRAY) {
@@ -4618,10 +4597,6 @@ int zend_may_throw(const zend_op *opline, const zend_op_array *op_array, zend_ss
46184597
return (t1 & MAY_BE_OBJECT) || (t2 & (MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE));
46194598
case ZEND_CAST:
46204599
switch (opline->extended_value) {
4621-
case IS_NULL:
4622-
return 0;
4623-
case _IS_BOOL:
4624-
return (t1 & MAY_BE_OBJECT);
46254600
case IS_LONG:
46264601
case IS_DOUBLE:
46274602
return (t1 & MAY_BE_OBJECT);
@@ -4630,8 +4605,9 @@ int zend_may_throw(const zend_op *opline, const zend_op_array *op_array, zend_ss
46304605
case IS_ARRAY:
46314606
return (t1 & MAY_BE_OBJECT);
46324607
case IS_OBJECT:
4633-
return (t1 & MAY_BE_ARRAY);
4608+
return 0;
46344609
default:
4610+
ZEND_ASSERT(0);
46354611
return 1;
46364612
}
46374613
case ZEND_ARRAY_KEY_EXISTS:

0 commit comments

Comments
 (0)