Promote "Session is not active" warning to exception

In normal circumstances, the session handler methods are not invoked when the session is not active.

Closes GH-7006

Author: kocsismate

ext/session/mod_user_class.c

@@ -19,8 +19,8 @@
 
 #define PS_SANITY_CHECK						\
 	if (PS(session_status) != php_session_active) { \
-		php_error_docref(NULL, E_WARNING, "Session is not active"); \
-		RETURN_FALSE; \
+		zend_throw_error(NULL, "Session is not active"); \
+		RETURN_THROWS(); \
 	} \
 	if (PS(default_mod) == NULL) { \
 		zend_throw_error(NULL, "Cannot call default session handler"); \

ext/session/tests/bug55688.phpt

@@ -9,7 +9,12 @@ session.save_handler=files
 <?php
 ini_set('session.save_handler', 'files');
 $x = new SessionHandler;
-$x->gc(1);
+
+try {
+    $x->gc(1);
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 ?>
---EXPECTF--
-Warning: SessionHandler::gc(): Session is not active in %s on line %d
+--EXPECT--
+Session is not active

ext/session/tests/bug67972.phpt

@@ -5,7 +5,12 @@ Bug #67972: SessionHandler Invalid memory read create_sid()
 --FILE--
 <?php
 
-(new SessionHandler)->create_sid();
+try {
+    (new SessionHandler)->create_sid();
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
+
 ?>
---EXPECTF--
-Warning: SessionHandler::create_sid(): Session is not active in %s on line %d
+--EXPECT--
+Session is not active

ext/session/tests/bug69111.phpt

@@ -12,14 +12,26 @@ $sessionName = ini_get('session.name');
 
 // session_start(); // Uncommenting this makes it not crash when reading the session (see below), but it will not return any data.
 
-$sh->open($savePath, $sessionName);
-$sh->write("foo", "bar");
-var_dump($sh->read(""));
-?>
---EXPECTF--
-Warning: SessionHandler::open(): Session is not active in %s on line 10
+try {
+    $sh->open($savePath, $sessionName);
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
+
+try {
+    $sh->write("foo", "bar");
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-Warning: SessionHandler::write(): Session is not active in %s on line 11
+try {
+    $sh->read("");
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-Warning: SessionHandler::read(): Session is not active in %s on line 12
-bool(false)
+?>
+--EXPECT--
+Session is not active
+Session is not active
+Session is not active

ext/session/tests/sessionhandler_open_001.phpt

@@ -7,20 +7,37 @@ Testing repated SessionHandler::open() calls
 
 ini_set('session.save_handler', 'files');
 $x = new SessionHandler;
-$x->open('','');
-$x->open('','');
-$x->open('','');
-$x->open('','');
 
-print "Done!\n";
+try {
+    $x->open('','');
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-?>
---EXPECTF--
-Warning: SessionHandler::open(): Session is not active in %s on line 5
+try {
+    $x->open('','');
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-Warning: SessionHandler::open(): Session is not active in %s on line 6
+try {
+    $x->open('','');
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-Warning: SessionHandler::open(): Session is not active in %s on line 7
+try {
+    $x->open('','');
+} catch (Error $exception) {
+    echo $exception->getMessage() . "\n";
+}
 
-Warning: SessionHandler::open(): Session is not active in %s on line 8
+print "Done!\n";
+
+?>
+--EXPECTF--
+Session is not active
+Session is not active
+Session is not active
+Session is not active
 Done!