Skip to content

Commit 28e650a

Browse files
committed
Revert "Merge branch 'PHP-7.4'"
This reverts commit 046dcfb, due to segfaults on Travis. This needs to be investigated.
1 parent 9c23a50 commit 28e650a

File tree

6 files changed

+4
-41
lines changed

6 files changed

+4
-41
lines changed

Zend/zend_portability.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -610,12 +610,4 @@ extern "C++" {
610610
# define ZEND_PREFER_RELOAD
611611
#endif
612612

613-
#if defined(ZEND_WIN32) && defined(_DEBUG) && defined(PHP_WIN32_DEBUG_HEAP)
614-
# define ZEND_IGNORE_LEAKS_BEGIN() _CrtSetDbgFlag(_CrtSetDbgFlag(_CRTDBG_REPORT_FLAG) & ~_CRTDBG_ALLOC_MEM_DF)
615-
# define ZEND_IGNORE_LEAKS_END() _CrtSetDbgFlag(_CrtSetDbgFlag(_CRTDBG_REPORT_FLAG) | _CRTDBG_ALLOC_MEM_DF)
616-
#else
617-
# define ZEND_IGNORE_LEAKS_BEGIN()
618-
# define ZEND_IGNORE_LEAKS_END()
619-
#endif
620-
621613
#endif /* ZEND_PORTABILITY_H */

Zend/zend_strtod.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,6 @@ Bigint {
546546
static Bigint *freelist[Kmax+1];
547547

548548
static void destroy_freelist(void);
549-
static void free_p5s(void);
550549

551550
#ifdef ZTS
552551
static MUTEX_T dtoa_mutex;
@@ -565,8 +564,6 @@ ZEND_API int zend_startup_strtod(void) /* {{{ */
565564
ZEND_API int zend_shutdown_strtod(void) /* {{{ */
566565
{
567566
destroy_freelist();
568-
free_p5s();
569-
570567
#ifdef ZTS
571568
tsrm_mutex_free(dtoa_mutex);
572569
dtoa_mutex = NULL;
@@ -4543,19 +4540,6 @@ static void destroy_freelist(void)
45434540
FREE_DTOA_LOCK(0)
45444541
}
45454542

4546-
static void free_p5s(void)
4547-
{
4548-
Bigint **listp, *tmp;
4549-
4550-
ACQUIRE_DTOA_LOCK(1)
4551-
listp = &p5s;
4552-
while ((tmp = *listp) != NULL) {
4553-
*listp = tmp->next;
4554-
free(tmp);
4555-
}
4556-
FREE_DTOA_LOCK(1)
4557-
}
4558-
45594543
#ifdef __cplusplus
45604544
}
45614545
#endif

Zend/zend_vm_execute.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59414,17 +59414,13 @@ void zend_vm_init(void)
5941459414
VM_TRACE_START();
5941559415
}
5941659416

59417-
static HashTable *zend_handlers_table = NULL;
59418-
5941959417
void zend_vm_dtor(void)
5942059418
{
5942159419
VM_TRACE_END();
59422-
if (zend_handlers_table) {
59423-
zend_hash_destroy(zend_handlers_table);
59424-
free(zend_handlers_table);
59425-
}
5942659420
}
5942759421

59422+
static HashTable *zend_handlers_table = NULL;
59423+
5942859424
static void init_opcode_serialiser(void)
5942959425
{
5943059426
int i;

Zend/zend_vm_execute.skl

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,13 @@ void {%INITIALIZER_NAME%}(void)
6767
VM_TRACE_START();
6868
}
6969

70-
static HashTable *zend_handlers_table = NULL;
71-
7270
void zend_vm_dtor(void)
7371
{
7472
VM_TRACE_END();
75-
if (zend_handlers_table) {
76-
zend_hash_destroy(zend_handlers_table);
77-
free(zend_handlers_table);
78-
}
7973
}
8074

75+
static HashTable *zend_handlers_table = NULL;
76+
8177
static void init_opcode_serialiser(void)
8278
{
8379
int i;

ext/libxml/config.w32

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ if (PHP_LIBXML == "yes") {
1616
ADD_DEF_FILE("ext\\libxml\\php_libxml2.def");
1717
}
1818
PHP_INSTALL_HEADERS("ext/libxml/", "php_libxml.h");
19-
if (PHP_CRT_DEBUG == "yes") {
20-
ADD_FLAG("CFLAGS_LIBXML", "/D PHP_WIN32_DEBUG_HEAP");
21-
}
2219
} else {
2320
WARNING("libxml support can't be enabled, iconv or libxml are missing")
2421
PHP_LIBXML = "no"

ext/libxml/libxml.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -724,9 +724,7 @@ PHP_LIBXML_API void php_libxml_initialize(void)
724724
{
725725
if (!_php_libxml_initialized) {
726726
/* we should be the only one's to ever init!! */
727-
ZEND_IGNORE_LEAKS_BEGIN();
728727
xmlInitParser();
729-
ZEND_IGNORE_LEAKS_END();
730728

731729
_php_libxml_default_entity_loader = xmlGetExternalEntityLoader();
732730
xmlSetExternalEntityLoader(_php_libxml_pre_ext_ent_loader);

0 commit comments

Comments
 (0)