TODO Comment

Girgias · Girgias · commit 288a4cf25e74 · 2020-07-21T14:16:20.000+01:00
diff --git a/ext/sodium/libsodium.c b/ext/sodium/libsodium.c
@@ -1787,6 +1787,7 @@ PHP_FUNCTION(sodium_crypto_pwhash_scryptsalsa208sha256_str_verify)
 		RETURN_THROWS();
 	}
 	if (hash_str_len != crypto_pwhash_scryptsalsa208sha256_STRBYTES - 1) {
+		/* Promote to Exception? */
 		zend_error(E_WARNING, "wrong size for the hashed password");
 		RETURN_FALSE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1787,6 +1787,7 @@ PHP_FUNCTION(sodium_crypto_pwhash_scryptsalsa208sha256_str_verify)`
`1787`	`1787`	`RETURN_THROWS();`
`1788`	`1788`	`}`
`1789`	`1789`	`if (hash_str_len != crypto_pwhash_scryptsalsa208sha256_STRBYTES - 1) {`
	`1790`	`+ /* Promote to Exception? */`
`1790`	`1791`	`zend_error(E_WARNING, "wrong size for the hashed password");`
`1791`	`1792`	`RETURN_FALSE;`
`1792`	`1793`	`}`