- Fixed bug #65227 (Memory leak in gmp_cmp second parameter)

felipensp · felipensp · commit 281936b29535 · 2013-07-12T20:23:00.000-03:00
diff --git a/NEWS b/NEWS
@@ -26,6 +26,9 @@ PHP                                                                        NEWS
   . Fixed bug #63983 (enabling FPM borks compile on FreeBSD).
     (chibisuke at web dot de, Felipe)
     
+- GMP:
+  . Fixed bug #65227 (Memory leak in gmp_cmp second parameter). (Felipe)
+
 - Imap:
   . Fixed bug #64467 (Segmentation fault after imap_reopen failure).
     (askalski at gmail dot com)
diff --git a/ext/gmp/gmp.c b/ext/gmp/gmp.c
@@ -1333,6 +1333,7 @@ ZEND_FUNCTION(gmp_cmp)
 		res = mpz_cmp_si(*gmpnum_a, Z_LVAL_PP(b_arg));
 	} else {
 		res = mpz_cmp(*gmpnum_a, *gmpnum_b);
+		FREE_GMP_TEMP(temp_b);
 	}
 	FREE_GMP_TEMP(temp_a);
 	

Original file line number	Diff line number	Diff line change
`@@ -1333,6 +1333,7 @@ ZEND_FUNCTION(gmp_cmp)`
`1333`	`1333`	`res = mpz_cmp_si(*gmpnum_a, Z_LVAL_PP(b_arg));`
`1334`	`1334`	`} else {`
`1335`	`1335`	`res = mpz_cmp(gmpnum_a, gmpnum_b);`
	`1336`	`+ FREE_GMP_TEMP(temp_b);`
`1336`	`1337`	`}`
`1337`	`1338`	`FREE_GMP_TEMP(temp_a);`
`1338`	`1339`