Clean up _property_check_dynamic

DanielEScherzer · DanielEScherzer · commit 27d00beb0901 · 2024-09-05T11:06:07.000-07:00
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -5921,7 +5921,7 @@ ZEND_METHOD(ReflectionProperty, isVirtual)
 	_property_check_flag(INTERNAL_FUNCTION_PARAM_PASSTHRU, ZEND_ACC_VIRTUAL);
 }
 
-static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamicTrue) /* {{{ */
+static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamic_true)
 {
 	reflection_object *intern;
 	property_reference *ref;
@@ -5930,8 +5930,8 @@ static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamicTr
 		RETURN_THROWS();
 	}
 	GET_REFLECTION_OBJECT_PTR(ref);
-	bool isDynamic = ref->prop == NULL;
-	RETURN_BOOL(dynamicTrue ? isDynamic : !isDynamic);
+	bool is_dynamic = ref->prop == NULL;
+	RETURN_BOOL(dynamic_true ? is_dynamic : !is_dynamic);
 }
 
 /* {{{ Returns whether this property is default (declared at compilation time). */

Original file line number	Diff line number	Diff line change
`@@ -5921,7 +5921,7 @@ ZEND_METHOD(ReflectionProperty, isVirtual)`
`5921`	`5921`	`_property_check_flag(INTERNAL_FUNCTION_PARAM_PASSTHRU, ZEND_ACC_VIRTUAL);`
`5922`	`5922`	`}`
`5923`	`5923`
`5924`		`-static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamicTrue) /* {{{ */`
	`5924`	`+static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamic_true)`
`5925`	`5925`	`{`
`5926`	`5926`	`reflection_object *intern;`
`5927`	`5927`	`property_reference *ref;`
`@@ -5930,8 +5930,8 @@ static void _property_check_dynamic(INTERNAL_FUNCTION_PARAMETERS, bool dynamicTr`
`5930`	`5930`	`RETURN_THROWS();`
`5931`	`5931`	`}`
`5932`	`5932`	`GET_REFLECTION_OBJECT_PTR(ref);`
`5933`		`- bool isDynamic = ref->prop == NULL;`
`5934`		`- RETURN_BOOL(dynamicTrue ? isDynamic : !isDynamic);`
	`5933`	`+ bool is_dynamic = ref->prop == NULL;`
	`5934`	`+ RETURN_BOOL(dynamic_true ? is_dynamic : !is_dynamic);`
`5935`	`5935`	`}`
`5936`	`5936`
`5937`	`5937`	`/* {{{ Returns whether this property is default (declared at compilation time). */`