Skip to content

Commit 2722dbf

Browse files
committed
Merge branch 'master' into sccp
* master: Resources should be closed during object destructioin, not during freeing. Guard against AppVeyor losing deps issue increase poll timeout as false positives mitigation Value of EG(user_exception_handler) should't relive request boundary sodium ext: remove function names before exception messages sodium ext: update the crypto_kx_*() API to the libsodium one Revert "fix macro redifinitions"
2 parents 6595ea3 + 09d3b73 commit 2722dbf

11 files changed

+356
-216
lines changed

Zend/zend_execute_API.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ void init_executor(void) /* {{{ */
154154
EG(ticks_count) = 0;
155155

156156
ZVAL_UNDEF(&EG(user_error_handler));
157+
ZVAL_UNDEF(&EG(user_exception_handler));
157158

158159
EG(current_execute_data) = NULL;
159160

appveyor/build_task.bat

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@ echo Updating dependencies in %DEPS_DIR%
2222
cmd /c phpsdk_deps --update --no-backup --branch %BRANCH% --stability %STABILITY% --deps %DEPS_DIR% --crt %PHP_BUILD_CRT%
2323
if %errorlevel% neq 0 exit /b 3
2424

25+
rem Something went wrong, most likely when concurrent builds were to fetch deps
26+
rem updates. It might be, that some locking mechanism is needed.
27+
if not exist "%DEPS_DIR%" (
28+
cmd /c phpsdk_deps --update --force --no-backup --branch %BRANCH% --stability %STABILITY% --deps %DEPS_DIR%
29+
)
30+
if %errorlevel% neq 0 exit /b 3
31+
2532
cmd /c buildconf.bat --force
2633
if %errorlevel% neq 0 exit /b 3
2734

ext/mysqli/tests/mysqli_reap_async_query.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ if (!$IS_MYSQLND)
3838

3939
function poll_async($offset, $link, $links, $errors, $reject, $exp_ready, $use_oo_syntax) {
4040

41-
if ($exp_ready !== ($tmp = mysqli_poll($links, $errors, $reject, 0, 1000)))
41+
if ($exp_ready !== ($tmp = mysqli_poll($links, $errors, $reject, 0, 2000)))
4242
printf("[%03d + 1] There should be %d links ready to read from, %d ready\n",
4343
$offset, $exp_ready, $tmp);
4444

0 commit comments

Comments
 (0)