Detect invalid uses of "static" earlier

Author: nikic

Zend/tests/type_declarations/static_type_outside_class.phpt

@@ -0,0 +1,10 @@
+--TEST--
+Static type outside class generates compile error
+--FILE--
+<?php
+
+function test(): static {}
+
+?>
+--EXPECTF--
+Fatal error: Cannot use "static" when no class scope is active in %s on line %d

Zend/tests/type_declarations/static_type_return.phpt

@@ -26,10 +26,6 @@ class B extends A {
 
 class C extends B {}
 
-function test(): static {
-    return new stdClass;
-}
-
 $a = new A;
 $b = new B;
 
@@ -57,12 +53,19 @@ try {
 }
 
 echo "\n";
+$test = function($x): static {
+    return $x;
+};
+
 try {
-    var_dump(test());
+    var_dump($test(new stdClass));
 } catch (TypeError $e) {
     echo $e->getMessage(), "\n";
 }
 
+$test = $test->bindTo($a);
+var_dump($test($a));
+
 ?>
 --EXPECT--
 object(A)#3 (0) {
@@ -83,4 +86,6 @@ object(A)#3 (0) {
 }
 Return value of A::test4() must be of type static|array, instance of A returned
 
-Return value of test() must be an instance of static, instance of stdClass returned
+Return value of {closure}() must be an instance of static, instance of stdClass returned
+object(A)#1 (0) {
+}

Zend/zend_compile.c

@@ -5464,6 +5464,10 @@ static zend_type zend_compile_single_typename(zend_ast *ast)
 {
 	ZEND_ASSERT(!(ast->attr & ZEND_TYPE_NULLABLE));
 	if (ast->kind == ZEND_AST_TYPE) {
+		if (ast->attr == IS_STATIC && !CG(active_class_entry) && zend_is_scope_known()) {
+			zend_error_noreturn(E_COMPILE_ERROR,
+				"Cannot use \"static\" when no class scope is active");
+		}
 		return (zend_type) ZEND_TYPE_INIT_CODE(ast->attr, 0, 0);
 	} else {
 		zend_string *class_name = zend_ast_get_str(ast);