Cleanup + drop todo comment

Girgias · Girgias · commit 26849b61aef5 · 2022-07-28T15:00:10.000+01:00
diff --git a/ext/dba/tests/dba_array_keys_inifile.phpt b/ext/dba/tests/dba_array_keys_inifile.phpt
@@ -10,7 +10,7 @@ check_skip('inifile');
 --FILE--
 <?php
 require_once __DIR__ . '/setup/setup_dba_tests.inc';
-$name = 'array_keys_inifle.db';
+$name = __DIR__ . '/array_keys_basic.db';
 
 $db = dba_open($name, 'c', 'inifile');
 
@@ -28,7 +28,7 @@ dba_close($db);
 --CLEAN--
 <?php
 require_once __DIR__ . '/setup/setup_dba_tests.inc';
-$db_name = 'array_keys_basic.db';
+$db_name = __DIR__ . '/array_keys_basic.db';
 cleanup_standard_db($db_name);
 ?>
 --EXPECTF--
diff --git a/ext/dba/tests/setup/setup_dba_tests.inc b/ext/dba/tests/setup/setup_dba_tests.inc
@@ -43,8 +43,6 @@ enum LockFlag: string {
     case NoLock = '-';
 }
 
-// TODO Test which opens a NON DB file to check for memory leaks (at least LMDB has)
-
 function set_up_db_ex(string $handler, string $name, LockFlag $lock, bool $persistent = false) {
     $lock_flag = $lock->value;
     // Open file in creation/truncation mode

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,6 @@ enum LockFlag: string {`
`43`	`43`	`case NoLock = '-';`
`44`	`44`	`}`
`45`	`45`
`46`		`-// TODO Test which opens a NON DB file to check for memory leaks (at least LMDB has)`
`47`		`-`
`48`	`46`	`function set_up_db_ex(string $handler, string $name, LockFlag $lock, bool $persistent = false) {`
`49`	`47`	`$lock_flag = $lock->value;`
`50`	`48`	`// Open file in creation/truncation mode`