Use dereferenced value

dstogov · dstogov · commit 24e595bf2627 · 2017-10-03T10:49:56.000+03:00
diff --git a/ext/oci8/oci8_statement.c b/ext/oci8/oci8_statement.c
@@ -1083,12 +1083,12 @@ int php_oci_bind_post_exec(zval *data)
 				}
 				break;
 		}
-	} else if ((Z_TYPE(bind->val) == IS_TRUE) || (Z_TYPE(bind->val) == IS_FALSE)) {
+	} else if ((Z_TYPE_P(zv) == IS_TRUE) || (Z_TYPE_P(zv) == IS_FALSE)) {
 		/* This convetrsion is done on purpose (ext/oci8 uses LVAL as a temorary value) */
-		if (Z_LVAL(bind->val) == 0)
-			ZVAL_BOOL(&bind->val, FALSE);
-		else if (Z_LVAL(bind->val) == 1)
-			ZVAL_BOOL(&bind->val, TRUE);
+		if (Z_LVAL_P(zv) == 0)
+			ZVAL_BOOL(zv, FALSE);
+		else if (Z_LVAL_P(zv) == 1)
+			ZVAL_BOOL(zv, TRUE);
 	}
 
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -1083,12 +1083,12 @@ int php_oci_bind_post_exec(zval *data)`
`1083`	`1083`	`}`
`1084`	`1084`	`break;`
`1085`	`1085`	`}`
`1086`		`- } else if ((Z_TYPE(bind->val) == IS_TRUE) \|\| (Z_TYPE(bind->val) == IS_FALSE)) {`
	`1086`	`+ } else if ((Z_TYPE_P(zv) == IS_TRUE) \|\| (Z_TYPE_P(zv) == IS_FALSE)) {`
`1087`	`1087`	`/* This convetrsion is done on purpose (ext/oci8 uses LVAL as a temorary value) */`
`1088`		`- if (Z_LVAL(bind->val) == 0)`
`1089`		`- ZVAL_BOOL(&bind->val, FALSE);`
`1090`		`- else if (Z_LVAL(bind->val) == 1)`
`1091`		`- ZVAL_BOOL(&bind->val, TRUE);`
	`1088`	`+ if (Z_LVAL_P(zv) == 0)`
	`1089`	`+ ZVAL_BOOL(zv, FALSE);`
	`1090`	`+ else if (Z_LVAL_P(zv) == 1)`
	`1091`	`+ ZVAL_BOOL(zv, TRUE);`
`1092`	`1092`	`}`
`1093`	`1093`
`1094`	`1094`	`return 0;`