Quoter refactoring nits

Girgias · Girgias · commit 1fb842985ea9 · 2021-01-06T01:20:53.000Z
diff --git a/ext/pdo_dblib/dblib_driver.c b/ext/pdo_dblib/dblib_driver.c
@@ -181,7 +181,7 @@ static zend_string* dblib_handle_quoter(pdo_dbh_t *dbh, const zend_string *unquo
 	*q++ = '\'';
 
 	for (i = 0; i < ZSTR_LEN(unquoted); i++) {
-		if (unquoted[i] == '\'') {
+		if (ZSTR_VAL(unquoted)[i] == '\'') {
 			*q++ = '\'';
 			*q++ = '\'';
 		} else {
diff --git a/ext/pdo_mysql/mysql_driver.c b/ext/pdo_mysql/mysql_driver.c
@@ -342,7 +342,6 @@ static zend_string* mysql_handle_quoter(pdo_dbh_t *dbh, const zend_string *unquo
 
 	quoted_str = zend_string_init(quoted, quotedlen, 0);
 	efree(quoted);
-	return quoted_str;
 	PDO_DBG_RETURN(quoted_str);
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,6 @@ static zend_string* mysql_handle_quoter(pdo_dbh_t dbh, const zend_string unquo`
`342`	`342`
`343`	`343`	`quoted_str = zend_string_init(quoted, quotedlen, 0);`
`344`	`344`	`efree(quoted);`
`345`		`- return quoted_str;`
`346`	`345`	`PDO_DBG_RETURN(quoted_str);`
`347`	`346`	`}`
`348`	`347`	`/* }}} */`