File tree 2 files changed +10
-13
lines changed 2 files changed +10
-13
lines changed Original file line number Diff line number Diff line change @@ -2243,6 +2243,9 @@ PHP_FUNCTION(mysqli_stmt_attr_set)
2243
2243
MY_STMT * stmt ;
2244
2244
zval * mysql_stmt ;
2245
2245
zend_long mode_in ;
2246
+ #if MYSQL_VERSION_ID >= 50107
2247
+ my_bool mode_b ;
2248
+ #endif
2246
2249
unsigned long mode ;
2247
2250
zend_long attr ;
2248
2251
void * mode_p ;
@@ -2256,16 +2259,13 @@ PHP_FUNCTION(mysqli_stmt_attr_set)
2256
2259
switch (attr ) {
2257
2260
#if MYSQL_VERSION_ID >= 50107
2258
2261
case STMT_ATTR_UPDATE_MAX_LENGTH :
2259
- {
2260
- //my_bool mode_b;
2261
2262
if (mode_in != 0 && mode_in != 1 ) {
2262
2263
zend_argument_value_error (ERROR_ARG_POS (3 ), "must be 0 or 1 for attribute MYSQLI_STMT_ATTR_UPDATE_MAX_LENGTH" );
2263
2264
RETURN_THROWS ();
2264
2265
}
2265
- mode = mode_in ; // (my_bool) mode_in;
2266
- mode_p = & mode ;
2266
+ mode_b = (my_bool ) mode_in ;
2267
+ mode_p = & mode_b ;
2267
2268
break ;
2268
- }
2269
2269
#endif
2270
2270
case STMT_ATTR_CURSOR_TYPE : {
2271
2271
switch (mode_in ) {
@@ -2301,12 +2301,7 @@ PHP_FUNCTION(mysqli_stmt_attr_set)
2301
2301
RETURN_THROWS ();
2302
2302
}
2303
2303
2304
- // TODO Can unify this?
2305
- #ifndef MYSQLI_USE_MYSQLND
2306
- if (mysql_stmt_attr_set (stmt -> stmt , attr , mode_p )) {
2307
- #else
2308
- if (FAIL == mysql_stmt_attr_set (stmt -> stmt , attr , mode_p )) {
2309
- #endif
2304
+ if (0 != mysql_stmt_attr_set (stmt -> stmt , attr , mode_p )) {
2310
2305
RETURN_FALSE ;
2311
2306
}
2312
2307
RETURN_TRUE ;
Original file line number Diff line number Diff line change @@ -71,8 +71,10 @@ require_once("connect.inc");
71
71
$ stmt ->prepare ("SELECT label FROM test " );
72
72
var_dump ($ stmt ->attr_set (MYSQLI_STMT_ATTR_UPDATE_MAX_LENGTH , 1 ));
73
73
$ res = $ stmt ->attr_get (MYSQLI_STMT_ATTR_UPDATE_MAX_LENGTH );
74
- if ($ res !== 1 )
75
- printf ("[007.1] max_length should be 1, got %s \n" , $ res );
74
+ if ($ res !== 1 ) {
75
+ printf ("[007.1] max_length should be int 1, got \n" );
76
+ var_dump ($ res );
77
+ }
76
78
$ stmt ->execute ();
77
79
$ stmt ->store_result ();
78
80
$ res = $ stmt ->result_metadata ();
You can’t perform that action at this time.
0 commit comments