Write to correct smart_str

nikic · nikic · commit 1e14b7a36910 · 2018-10-03T11:03:55.000+02:00
Mixed this up during the migration to ZEND_HASH_FOREACH.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -975,7 +975,7 @@ static void _extension_string(smart_str *str, zend_module_entry *module, char *i
 
 		ZEND_HASH_FOREACH_PTR(EG(zend_constants), constant) {
 			if (ZEND_CONSTANT_MODULE_NUMBER(constant) == module->module_number) {
-				_const_string(str, ZSTR_VAL(constant->name), &constant->value, indent);
+				_const_string(&str_constants, ZSTR_VAL(constant->name), &constant->value, indent);
 				num_constants++;
 			}
 		} ZEND_HASH_FOREACH_END();

Original file line number	Diff line number	Diff line change
`@@ -975,7 +975,7 @@ static void _extension_string(smart_str str, zend_module_entry module, char *i`
`975`	`975`
`976`	`976`	`ZEND_HASH_FOREACH_PTR(EG(zend_constants), constant) {`
`977`	`977`	`if (ZEND_CONSTANT_MODULE_NUMBER(constant) == module->module_number) {`
`978`		`- _const_string(str, ZSTR_VAL(constant->name), &constant->value, indent);`
	`978`	`+ _const_string(&str_constants, ZSTR_VAL(constant->name), &constant->value, indent);`
`979`	`979`	`num_constants++;`
`980`	`980`	`}`
`981`	`981`	`} ZEND_HASH_FOREACH_END();`