Skip to content

Commit 1db2667

Browse files
committed
Remove fiber ID property
1 parent 3081f2b commit 1db2667

File tree

4 files changed

+2
-12
lines changed

4 files changed

+2
-12
lines changed

Zend/zend.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,6 @@ static void executor_globals_ctor(zend_executor_globals *executor_globals) /* {{
761761
executor_globals->exception = NULL;
762762
executor_globals->objects_store.object_buckets = NULL;
763763
executor_globals->current_fiber = NULL;
764-
executor_globals->next_fiber_id = 0;
765764
executor_globals->fiber_error = NULL;
766765
#ifdef ZEND_WIN32
767766
zend_get_windows_version_info(&executor_globals->windows_version_info);

Zend/zend_fibers.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -413,12 +413,10 @@ static zend_object *zend_fiber_object_create(zend_class_entry *ce) /* {{{ */
413413
fiber = emalloc(sizeof(zend_fiber));
414414
memset(fiber, 0, sizeof(zend_fiber));
415415

416-
fiber->id = EG(next_fiber_id)++;
417-
418416
zend_object_std_init(&fiber->std, ce);
419417
fiber->std.handlers = &zend_fiber_handlers;
420418

421-
zend_hash_index_add_ptr(&EG(fibers), fiber->id, fiber);
419+
zend_hash_index_add_ptr(&EG(fibers), (uintptr_t) fiber, fiber);
422420

423421
return &fiber->std;
424422
}
@@ -443,7 +441,7 @@ static void zend_fiber_object_destroy(zend_object *object) /* {{{ */
443441
zval_ptr_dtor(&fiber->value);
444442
}
445443

446-
zend_hash_index_del(&EG(fibers), fiber->id);
444+
zend_hash_index_del(&EG(fibers), (uintptr_t) fiber);
447445

448446
zend_fiber_destroy_context(&fiber->context);
449447

@@ -783,7 +781,6 @@ void zend_register_fiber_ce(void)
783781
void zend_fiber_init(void)
784782
{
785783
EG(current_fiber) = NULL;
786-
EG(next_fiber_id) = 0;
787784
EG(fiber_error) = NULL;
788785

789786
zend_hash_init(&EG(fibers), 0, NULL, NULL, 0);

Zend/zend_fibers.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ typedef struct _zend_fiber {
6060
/* Fiber PHP object handle. */
6161
zend_object std;
6262

63-
/* Unique ID assigned to this fiber. */
64-
zend_long id;
65-
6663
/* Status of the fiber, one of the ZEND_FIBER_STATUS_* constants. */
6764
zend_uchar status;
6865

Zend/zend_globals.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,6 @@ struct _zend_executor_globals {
254254
/* Active fiber, NULL when in main thread. */
255255
zend_fiber *current_fiber;
256256

257-
/* Next fiber ID. */
258-
zend_long next_fiber_id;
259-
260257
/* Default fiber C stack size. */
261258
zend_long fiber_stack_size;
262259

0 commit comments

Comments
 (0)