Skip to content

Commit 1d45357

Browse files
committed
Tidy up UT and add NEWS entry
1 parent 19d2b84 commit 1d45357

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,9 @@ PHP NEWS
104104
- PDO_MYSQL:
105105
. Fixed setAttribute and getAttribute. (SakiTakamachi)
106106
. Added class PdoMysql. (danack, kocsismate)
107+
. Fixed binding of Stringable objects. (SakiTakamachi)
108+
. Added an error message when a non-scalar value is bound with PARAM_INT.
109+
(SakiTakamachi)
107110

108111
- PDO_ODBC:
109112
. Added class PdoOdbc. (danack, kocsismate)

ext/pdo_mysql/tests/gh13384.phpt

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,15 @@ $stringableObject = new class () implements Stringable {
2222
};
2323

2424
echo "Stringable object, value set after bindParam:\n";
25-
try {
26-
$stmt = $db->prepare('SELECT ?');
27-
$param = 'foo';
28-
$stmt->bindParam(1, $param, PDO::PARAM_STR);
29-
$param = $stringableObject;
30-
$stmt->execute();
31-
var_dump(is_object($param), $param === $stringableObject);
32-
echo "\n";
33-
} catch (Throwable $e) {
34-
echo $e->getMessage()."\n\n";
35-
}
25+
26+
$stmt = $db->prepare('SELECT ?');
27+
$param = 'foo';
28+
$stmt->bindParam(1, $param, PDO::PARAM_STR);
29+
$param = $stringableObject;
30+
$stmt->execute();
31+
var_dump(is_object($param), $param === $stringableObject);
32+
echo "\n";
33+
3634

3735
echo "Stringable object, bindValue:\n";
3836
$stmt = $db->prepare('SELECT (?)');

0 commit comments

Comments
 (0)