Skip to content

Commit 1d045a5

Browse files
committed
Use RETVAL_BOOL or RETURN_BOOL in ext/tidy
1 parent 09c0455 commit 1d045a5

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

ext/tidy/tidy.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1424,12 +1424,8 @@ PHP_METHOD(tidy, parseFile)
14241424
RETURN_THROWS();
14251425
}
14261426

1427-
if (php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) != SUCCESS
1428-
|| php_tidy_parse_string(obj, ZSTR_VAL(contents), (uint32_t)ZSTR_LEN(contents), enc) != SUCCESS) {
1429-
RETVAL_FALSE;
1430-
} else {
1431-
RETVAL_TRUE;
1432-
}
1427+
RETVAL_BOOL(php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) == SUCCESS
1428+
&& php_tidy_parse_string(obj, ZSTR_VAL(contents), (uint32_t)ZSTR_LEN(contents), enc) == SUCCESS);
14331429

14341430
zend_string_release_ex(contents, 0);
14351431
}
@@ -1457,12 +1453,8 @@ PHP_METHOD(tidy, parseString)
14571453
TIDY_SET_CONTEXT;
14581454
obj = Z_TIDY_P(object);
14591455

1460-
if (php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) == SUCCESS
1461-
&& php_tidy_parse_string(obj, ZSTR_VAL(input), (uint32_t)ZSTR_LEN(input), enc) == SUCCESS) {
1462-
RETURN_TRUE;
1463-
}
1464-
1465-
RETURN_FALSE;
1456+
RETURN_BOOL(php_tidy_apply_config(obj->ptdoc->doc, options_str, options_ht) == SUCCESS
1457+
&& php_tidy_parse_string(obj, ZSTR_VAL(input), (uint32_t)ZSTR_LEN(input), enc) == SUCCESS);
14661458
}
14671459

14681460

0 commit comments

Comments
 (0)